Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: Arnd Bergmann <arnd@arndb.de>, James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>
Cc: David Howells <dhowells@redhat.com>,
	Kees Cook <keescook@chromium.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smack: include linux/watch_queue.h
Date: Mon, 23 Sep 2019 14:50:48 -0700
Message-ID: <dbbf0b7a-125c-9517-4232-dd88bea139dd@schaufler-ca.com> (raw)
In-Reply-To: <20190909204631.1076624-1-arnd@arndb.de>

On 9/9/2019 1:46 PM, Arnd Bergmann wrote:
> In some randconfig builds, the lack of an explicit #include
> in smack_lsm.c causes a build failure:

What tree/branch are you working with? I don't see this.

>
> security/smack/smack_lsm.c:4384:7: error: incomplete definition of type 'struct watch_notification'
>         if (n->type == WATCH_TYPE_META)
>             ~^
> include/linux/device.h:46:8: note: forward declaration of 'struct watch_notification'
> struct watch_notification;
>        ^
> security/smack/smack_lsm.c:4384:17: error: use of undeclared identifier 'WATCH_TYPE_META'
>         if (n->type == WATCH_TYPE_META)
>
> Fixes: 5301fef8ca60 ("smack: Implement the watch_key and post_notification hooks [untested]")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  security/smack/smack_lsm.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index a15e76489683..5120dd9c6335 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -42,6 +42,7 @@
>  #include <linux/parser.h>
>  #include <linux/fs_context.h>
>  #include <linux/fs_parser.h>
> +#include <linux/watch_queue.h>
>  #include "smack.h"
>  
>  #define TRANS_TRUE	"TRUE"

  parent reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-09 20:46 Arnd Bergmann
2019-09-10  3:40 ` kbuild test robot
2019-09-10  4:02 ` kbuild test robot
2019-09-23 21:50 ` Casey Schaufler [this message]
2019-09-24  1:24   ` Arnd Bergmann

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbbf0b7a-125c-9517-4232-dd88bea139dd@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=arnd@arndb.de \
    --cc=dhowells@redhat.com \
    --cc=jmorris@namei.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org
	public-inbox-index linux-security-module

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git