From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D654EC4321E for ; Thu, 17 Nov 2022 18:43:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240640AbiKQSm7 (ORCPT ); Thu, 17 Nov 2022 13:42:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240656AbiKQSm6 (ORCPT ); Thu, 17 Nov 2022 13:42:58 -0500 Received: from smtp-190a.mail.infomaniak.ch (smtp-190a.mail.infomaniak.ch [185.125.25.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C208086A4E for ; Thu, 17 Nov 2022 10:42:57 -0800 (PST) Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4NCph00gQyzMpnsN; Thu, 17 Nov 2022 19:42:56 +0100 (CET) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4NCpgz3dPJzMppF7; Thu, 17 Nov 2022 19:42:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1668710576; bh=fYc9X97hnclwNG+H0gFe0zOj3YwA4juRfn/QqOEsmLM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uqok18y1hHIXiiPXTqawR9yqncT2lTGEjfPTEDP7WZRTu6cvQyI9TijEBeEwOifV9 Q7GoYr3n0XyUTPjiWcFM9Hxx+Zh5JA6UmeE6QcJUoZMJjLy7CzZZ3+TbDUiGjYqQxE jlpvPY3IiF4WYW518Wy9SOPdfjPRDookoh8Di7nU= Message-ID: Date: Thu, 17 Nov 2022 19:42:54 +0100 MIME-Version: 1.0 User-Agent: Subject: Re: [PATCH v8 06/12] landlock: Refactor landlock_add_rule() syscall Content-Language: en-US To: Konstantin Meskhidze Cc: willemdebruijn.kernel@gmail.com, gnoack3000@gmail.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, artem.kuzin@huawei.com References: <20221021152644.155136-1-konstantin.meskhidze@huawei.com> <20221021152644.155136-7-konstantin.meskhidze@huawei.com> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= In-Reply-To: <20221021152644.155136-7-konstantin.meskhidze@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: On 21/10/2022 17:26, Konstantin Meskhidze wrote: > Modifies landlock_add_rule() syscall to support new rule types in future Change the landlock_add_rule() syscall… > Landlock versions. Adds add_rule_path_beneath() helper to support Add the… > current filesystem rules. > > Signed-off-by: Konstantin Meskhidze > --- > > Changes since v7: > * None > > Changes since v6: > * None > > Changes since v5: > * Refactors syscall landlock_add_rule() and add_rule_path_beneath() helper > to make argument check ordering consistent and get rid of partial revertings > in following patches. > * Rolls back refactoring base_test.c seltest. > * Formats code with clang-format-14. > > Changes since v4: > * Refactors add_rule_path_beneath() and landlock_add_rule() functions > to optimize code usage. > * Refactors base_test.c seltest: adds LANDLOCK_RULE_PATH_BENEATH > rule type in landlock_add_rule() call. > > Changes since v3: > * Split commit. > * Refactors landlock_add_rule syscall. > > --- > security/landlock/syscalls.c | 92 +++++++++++++++++++----------------- > 1 file changed, 48 insertions(+), 44 deletions(-) > > diff --git a/security/landlock/syscalls.c b/security/landlock/syscalls.c > index 71aca7f990bc..87389d7bfbf2 100644 > --- a/security/landlock/syscalls.c > +++ b/security/landlock/syscalls.c > @@ -274,6 +274,47 @@ static int get_path_from_fd(const s32 fd, struct path *const path) > return err; > } > > +static int add_rule_path_beneath(struct landlock_ruleset *const ruleset, > + const void __user *const rule_attr) > +{ > + struct landlock_path_beneath_attr path_beneath_attr; > + struct path path; > + int res, err; > + u32 mask; access_mask_t mask;