From: James Bottomley <jejb@linux.ibm.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Mimi Zohar <zohar@linux.ibm.com>,
David Howells <dhowells@redhat.com>,
Jens Wiklander <jens.wiklander@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Janne Karhunen <janne.karhunen@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Markus Wamser <Markus.Wamser@mixed-mode.de>,
Luke Hinds <lhinds@redhat.com>,
Elaine Palmer <erpalmer@us.ibm.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
"open list:ASYMMETRIC KEYS" <keyrings@vger.kernel.org>,
linux-integrity <linux-integrity@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH v9 1/4] KEYS: trusted: Add generic trusted keys framework
Date: Wed, 21 Apr 2021 10:20:59 -0700 [thread overview]
Message-ID: <e7a91c8c09722afe1fb1ec3aa7b6544e713183af.camel@linux.ibm.com> (raw)
In-Reply-To: <CAFA6WYOzD-qhHrcnzvd9P7iFvEqWwf0NCKXrgrEgvnB5i_-SxQ@mail.gmail.com>
On Wed, 2021-04-21 at 16:38 +0530, Sumit Garg wrote:
> Hi James,
>
> On Wed, 21 Apr 2021 at 04:47, James Bottomley <jejb@linux.ibm.com>
> wrote:
> > On Mon, 2021-03-01 at 18:41 +0530, Sumit Garg wrote:
> > > Current trusted keys framework is tightly coupled to use TPM
> > > device as an underlying implementation which makes it difficult
> > > for implementations like Trusted Execution Environment (TEE) etc.
> > > to provide trusted keys support in case platform doesn't posses a
> > > TPM device.
> > >
> > > Add a generic trusted keys framework where underlying
> > > implementations can be easily plugged in. Create struct
> > > trusted_key_ops to achieve this, which contains necessary
> > > functions of a backend.
> > >
> > > Also, define a module parameter in order to select a particular
> > > trust source in case a platform support multiple trust sources.
> > > In case its not specified then implementation itetrates through
> > > trust sources list starting with TPM and assign the first trust
> > > source as a backend which has initiazed successfully during
> > > iteration.
> > >
> > > Note that current implementation only supports a single trust
> > > source at runtime which is either selectable at compile time or
> > > during boot via aforementioned module parameter.
> >
> > You never actually tested this, did you? I'm now getting EINVAL
> > from all the trusted TPM key operations because of this patch.
> >
>
> Unfortunately, I don't possess a development machine with a TPM
> device. So mine testing was entirely based on TEE as a backend which
> doesn't support any optional parameters. And that being the reason I
> didn't catch this issue at first instance.
>
> Is there any TPM emulation environment available that I can use for
> testing?
Well use the same as we all use: A software TPM running in the host
coupled with a virtual machine guest for the kernel:
https://en.opensuse.org/Software_TPM_Emulator_For_QEMU
It doesn't catch interface issues (like TIS timeouts) but it does catch
TPM operations problems like this patch had.
James
next prev parent reply other threads:[~2021-04-21 17:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 13:11 [PATCH v9 0/4] Introduce TEE based Trusted Keys support Sumit Garg
2021-03-01 13:11 ` [PATCH v9 1/4] KEYS: trusted: Add generic trusted keys framework Sumit Garg
2021-03-01 21:29 ` Jarkko Sakkinen
2021-04-20 23:16 ` James Bottomley
2021-04-21 11:08 ` Sumit Garg
2021-04-21 17:20 ` James Bottomley [this message]
2021-04-22 4:47 ` Sumit Garg
2021-03-01 13:11 ` [PATCH v9 2/4] KEYS: trusted: Introduce TEE based Trusted Keys Sumit Garg
2021-03-01 21:29 ` Jarkko Sakkinen
2021-03-01 13:11 ` [PATCH v9 3/4] doc: trusted-encrypted: updates with TEE as a new trust source Sumit Garg
2021-03-01 13:11 ` [PATCH v9 4/4] MAINTAINERS: Add entry for TEE based Trusted Keys Sumit Garg
2021-03-04 10:00 ` [PATCH v9 0/4] Introduce TEE based Trusted Keys support Sumit Garg
2021-03-04 15:43 ` Jarkko Sakkinen
2021-03-09 9:10 ` Sumit Garg
2021-03-10 19:56 ` Jarkko Sakkinen
2021-03-10 22:26 ` James Bottomley
2021-03-10 23:35 ` Jarkko Sakkinen
2021-03-10 23:41 ` Jarkko Sakkinen
2021-03-12 16:26 ` Jarkko Sakkinen
2021-03-12 16:30 ` James Bottomley
2021-03-13 10:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7a91c8c09722afe1fb1ec3aa7b6544e713183af.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=Markus.Wamser@mixed-mode.de \
--cc=a.fatoum@pengutronix.de \
--cc=casey@schaufler-ca.com \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=dhowells@redhat.com \
--cc=erpalmer@us.ibm.com \
--cc=janne.karhunen@gmail.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jens.wiklander@linaro.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=lhinds@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).