From: Vasily Averin <vvs@virtuozzo.com>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [PATCH 1/1] proc_keys_next should increase position index
Date: Mon, 27 Jan 2020 22:27:47 +0300 [thread overview]
Message-ID: <eaacb0b2-fd0d-480e-1868-0a1284c20185@virtuozzo.com> (raw)
In-Reply-To: <1451508.1580125174@warthog.procyon.org.uk>
On 1/27/20 2:39 PM, David Howells wrote:
> I don't see the effect you're talking about with /proc/keys. I see the
> following:
>
> [root@andromeda ~]# dd if=/proc/keys bs=40 skip=1
> dd: /proc/keys: cannot skip to specified offset
>
> and then it follows up with the normal content with no obvious duplicates (the
> lines are numbered ascendingly in the first column).
>
> I think I may be being confused by what you mean by "the last line".
on unpatched kernel
$ uname -a
Linux vvsx1 5.3.0-26-generic #28~18.04.1-Ubuntu SMP Wed Dec 18 16:40:14 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
$ dd if=/proc/keys bs=1 # VvS: full usual output
0f6bfdf5 I--Q--- 2 perm 3f010000 1000 1000 user 4af2f79ab8848d0a: 740
1fb91b32 I--Q--- 3 perm 1f3f0000 1000 65534 keyring _uid.1000: 2
27589480 I--Q--- 1 perm 0b0b0000 0 0 user invocation_id: 16
2f33ab67 I--Q--- 152 perm 3f030000 0 0 keyring _ses: 2
33f1d8fa I--Q--- 4 perm 3f030000 1000 1000 keyring _ses: 1
3d427fda I--Q--- 2 perm 3f010000 1000 1000 user 69ec44aec7678e5a: 740
3ead4096 I--Q--- 1 perm 1f3f0000 1000 65534 keyring _uid_ses.1000: 1
521+0 records in
521+0 records out
521 bytes copied, 0,00123769 s, 421 kB/s
$ dd if=/proc/keys bs=500 skip=1 # read after lseek in middle of last line
dd: /proc/keys: cannot skip to specified offset
g _uid_ses.1000: 1 <<<< end of last line
3ead4096 I--Q--- 1 perm 1f3f0000 1000 65534 keyring _uid_ses.1000: 1 <<<< and whole last lien again
0+1 records in
0+1 records out
97 bytes copied, 0,000135035 s, 718 kB/s
$ dd if=/proc/keys bs=1000 skip=1 # read after lseek beyond end of file
dd: /proc/keys: cannot skip to specified offset
3ead4096 I--Q--- 1 perm 1f3f0000 1000 65534 keyring _uid_ses.1000: 1 <<<< generates last line
0+1 records in
0+1 records out
76 bytes copied, 0,000119981 s, 633 kB/s
On patched kernel:
[test@localhost ~]$ uname -a
Linux localhost.localdomain 5.5.0-rc6-00151-gd8d014f #8 SMP Fri Jan 24 13:25:06 MSK 2020 x86_64 x86_64 x86_64 GNU/Linux
[test@localhost ~]$ dd if=/proc/keys bs=1
06e8bec5 I--Q--- 4 perm 1f3f0000 1000 65534 keyring _uid.1000: empty
1b7ee8ed I--Q--- 11 perm 3f030000 1000 1000 keyring _ses: 1
2c1a365d I--Q--- 1 perm 1f3f0000 1000 65534 keyring _uid_ses.1000: 1
3f5823b4 I--Q--- 6 perm 3f030000 1000 1000 keyring _ses: 1
286+0 records in
286+0 records out
286 bytes copied, 0,000414581 s, 690 kB/s
[test@localhost ~]$ dd if=/proc/keys bs=270 skip=1 # VvS: read after lseek in middle of last line
dd: /proc/keys: cannot skip to specified offset
yring _ses: 1 <<<< only end of last line was generated, as expected
0+1 records in
0+1 records out
16 bytes copied, 7,7199e-05 s, 207 kB/s
[test@localhost ~]$ dd if=/proc/keys bs=1000 skip=1 # VvS: read after lseek beond end of file
dd: /proc/keys: cannot skip to specified offset
0+0 records in <<<< nothing was generated, as expected
0+0 records out
0 bytes copied, 8,8036e-05 s, 0,0 kB/s
next prev parent reply other threads:[~2020-01-27 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 6:25 [PATCH 1/1] proc_keys_next should increase position index Vasily Averin
2020-01-27 11:39 ` David Howells
2020-01-27 19:27 ` Vasily Averin [this message]
2020-01-30 10:16 ` [PATCH v2] keys: " Vasily Averin
2020-01-31 17:19 ` David Howells
2020-02-01 7:54 ` Vasily Averin
2020-01-30 8:42 ` [PATCH 1/1] " Jarkko Sakkinen
2020-01-30 8:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaacb0b2-fd0d-480e-1868-0a1284c20185@virtuozzo.com \
--to=vvs@virtuozzo.com \
--cc=dhowells@redhat.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).