From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Christoph Hellwig <hch@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
ast@kernel.org, axboe@kernel.dk, bfields@fieldses.org,
bridge@lists.linux-foundation.org, chainsaw@gentoo.org,
christian.brauner@ubuntu.com, chuck.lever@oracle.com,
davem@davemloft.net, dhowells@redhat.com,
gregkh@linuxfoundation.org, jarkko.sakkinen@linux.intel.com,
jmorris@namei.org, josh@joshtriplett.org, keescook@chromium.org,
keyrings@vger.kernel.org, kuba@kernel.org,
lars.ellenberg@linbit.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-security-module@vger.kernel.org,
nikolay@cumulusnetworks.com, philipp.reisner@linbit.com,
ravenexp@gmail.com, roopa@cumulusnetworks.com, serge@hallyn.com,
slyfox@gentoo.org, viro@zeniv.linux.org.uk,
yangtiezhu@loongson.cn, netdev@vger.kernel.org,
markward@linux.ibm.com, linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected)
Date: Wed, 1 Jul 2020 18:01:59 +0200 [thread overview]
Message-ID: <eb0b2ec2-52db-81a4-11b0-c0112b39a7aa@de.ibm.com> (raw)
In-Reply-To: <20200701155819.GU4332@42.do-not-panic.com>
On 01.07.20 17:58, Luis Chamberlain wrote:
[...]
>>>
>>> Ah, well that would be a different fix required, becuase again,
>>> br_stp_start() does not untangle the correct error today really.
>>> I also I think it would be odd odd that SIGSEGV or another signal
>>> is what was terminating Christian's bridge stp call, but let's
>>> find out!
>>>
>>> Note we pass 0 to the options to wait so the mistake here could indeed
>>> be that we did not need KWIFSIGNALED(). I was afraid of this prospect...
>>> as it other implications.
>>>
>>> It means we either *open code* all callers, or we handle this in a
>>> unified way on the umh. And if we do handle this in a unified way, it
>>> then begs the question as to *what* do we pass for the signals case and
>>> continued case. Below we just pass the signal, and treat continued as
>>> OK, but treating continued as OK would also be a *new* change as well.
>>>
>>> For instance (this goes just boot tested, but Christian if you can
>>> try this as well that would be appreciated):
>>
>>
>> Does not help, the bridge stays in DOWN state.
>
> OK thanks for testing, that was fast! Does your code go through the
> STP kernel path or userpath? If it is taking the STP kernel path
> then this is not the real culprit to your issue then.
I have no idea and I cannot look into this right now. I can test
patches as compile,reboot and test is almost no effort.
FWIW, this is just the network of a KVM guest of libvirts default network
no longer working, maybe you can reproduce this on x86 as well?
next prev parent reply other threads:[~2020-07-01 16:03 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 15:49 [PATCH 0/5] kmod/umh: a few fixes Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 1/5] selftests: kmod: Use variable NAME in kmod_test_0001() Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 2/5] kmod: Remove redundant "be an" in the comment Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 3/5] test_kmod: Avoid potential double free in trigger_config_run_type() Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 4/5] umh: fix processed error when UMH_WAIT_PROC is used Luis R. Rodriguez
2020-06-23 14:11 ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-23 14:23 ` Christian Borntraeger
2020-06-24 11:11 ` Christian Borntraeger
2020-06-24 12:05 ` Luis Chamberlain
2020-06-24 13:17 ` Luis Chamberlain
2020-06-24 16:13 ` Luis Chamberlain
2020-06-24 14:43 ` Christoph Hellwig
2020-06-24 15:54 ` Christian Borntraeger
2020-06-24 16:09 ` Luis Chamberlain
2020-06-24 17:58 ` Christian Borntraeger
2020-06-24 18:09 ` Christian Borntraeger
2020-06-24 18:32 ` Christian Borntraeger
2020-06-24 18:37 ` Christian Borntraeger
2020-06-25 13:26 ` Christian Borntraeger
2020-06-26 2:54 ` Luis Chamberlain
2020-06-26 5:22 ` Christian Borntraeger
2020-06-26 9:00 ` Christoph Hellwig
2020-06-26 11:40 ` Luis Chamberlain
2020-06-26 11:50 ` Luis Chamberlain
2020-06-30 17:57 ` Luis Chamberlain
2020-07-01 10:08 ` Christian Borntraeger
2020-07-01 13:24 ` Tetsuo Handa
2020-07-01 13:53 ` Luis Chamberlain
2020-07-01 14:08 ` Tetsuo Handa
2020-07-01 15:38 ` Luis Chamberlain
2020-07-01 15:48 ` Christian Borntraeger
2020-07-01 15:58 ` Luis Chamberlain
2020-07-01 16:01 ` Christian Borntraeger [this message]
2020-07-02 4:26 ` Tetsuo Handa
2020-07-02 19:46 ` Luis Chamberlain
2020-07-03 0:52 ` Tetsuo Handa
2020-07-03 13:28 ` Luis Chamberlain
2020-07-01 15:26 ` Christian Borntraeger
2020-07-01 13:46 ` Luis Chamberlain
2020-06-10 15:49 ` [PATCH 5/5] selftests: simplify kmod failure value Luis R. Rodriguez
2020-06-18 0:43 ` [PATCH 0/5] kmod/umh: a few fixes Andrew Morton
2020-06-19 20:46 ` Luis Chamberlain
2020-06-19 21:07 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0b2ec2-52db-81a4-11b0-c0112b39a7aa@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bfields@fieldses.org \
--cc=bridge@lists.linux-foundation.org \
--cc=chainsaw@gentoo.org \
--cc=christian.brauner@ubuntu.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=markward@linux.ibm.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=philipp.reisner@linbit.com \
--cc=ravenexp@gmail.com \
--cc=roopa@cumulusnetworks.com \
--cc=serge@hallyn.com \
--cc=slyfox@gentoo.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).