From: Casey Schaufler <casey@schaufler-ca.com>
To: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org, linux-security-module@vger.kernel.org,
Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: [PATCH] [RFC] xfs: initialise attr fork on inode create
Date: Mon, 7 Dec 2020 09:22:13 -0800 [thread overview]
Message-ID: <f39eb0d7-e437-5dae-303a-bae399e4bada@schaufler-ca.com> (raw)
In-Reply-To: <20201204075405.GA30060@infradead.org>
On 12/3/2020 11:54 PM, Christoph Hellwig wrote:
> On Fri, Dec 04, 2020 at 08:44:26AM +1100, Dave Chinner wrote:
>>>> + if ((IS_ENABLED(CONFIG_SECURITY) && dir->i_sb->s_security) ||
>>>> + default_acl || acl)
>>>> + need_xattr = true;
>>>> +
>>>> + error = xfs_create(XFS_I(dir), &name, mode, rdev,
>>>> + need_xattr, &ip);
>>> It might be wort to factor the condition into a little helper. Also
>>> I think we also have security labels for O_TMPFILE inodes, so it might
>>> be worth plugging into that path as well.
>> Yeah, a helper is a good idea - I just wanted to get some feedback
>> first on whether it's a good idea to peek directly at
>> i_sb->s_security
Only security modules should ever look at what's in the security blob.
In fact, you can't assume that the presence of a security blob
(i.e. ...->s_security != NULL) implies "need_xattr", or any other
state for the superblock.
>> or whether there is some other way of knowing ahead
>> of time that a security xattr is going to be created. I couldn't
>> find one, but that doesn't mean such an interface doesn't exist in
>> all the twisty passages of the LSM layers...
> I've added the relevant list, maybe someone there has an opinion.
How is what you're looking for different from security_ismaclabel() ?
next prev parent reply other threads:[~2020-12-07 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201202232724.1730114-1-david@fromorbit.com>
[not found] ` <20201203084012.GA32480@infradead.org>
[not found] ` <20201203214426.GE3913616@dread.disaster.area>
2020-12-04 7:54 ` [PATCH] [RFC] xfs: initialise attr fork on inode create Christoph Hellwig
2020-12-07 17:22 ` Casey Schaufler [this message]
2020-12-07 17:25 ` Christoph Hellwig
2020-12-07 20:49 ` Dave Chinner
2020-12-07 17:31 ` Christoph Hellwig
2020-12-07 20:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f39eb0d7-e437-5dae-303a-bae399e4bada@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).