From: John Johansen <john.johansen@canonical.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Xiyu Yang <xiyuyang19@fudan.edu.cn>,
Xin Tan <tanxin.ctf@gmail.com>,
linux-security-module@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>,
Kangjie Lu <kjlu@umn.edu>, "Serge E. Hallyn" <serge@hallyn.com>,
Yuan Zhang <yuanxzhang@fudan.edu.cn>
Subject: Re: [PATCH v2] apparmor: fix potential label refcnt leak in aa_change_profile
Date: Wed, 15 Apr 2020 11:41:27 -0700 [thread overview]
Message-ID: <f5930264-946a-ad70-a327-62117499681b@canonical.com> (raw)
In-Reply-To: <e9f36822-2483-9512-732b-b158ed104bf2@web.de>
On 4/15/20 4:27 AM, Markus Elfring wrote:
>> According to the comment of aa_get_current_label(), …
>
> I suggest to make this wording clearer.
> Would you like to refer to any software documentation here?
>
>
>> However, when the original object pointed by "label" becomes
>> unreachable because aa_change_profile() returns or a new object
>> is assigned to "label", reference count increased by
>> aa_get_current_label() is not decreased, causing a refcnt leak.
>
> How do you think about to reduce abbreviations in the commit message?
>
> Would you like to add the tag “Fixes” to the change description?
>
Fixes tags are always nice to have filled out, but some times its
hard to determine or the patch submitter doesn't know how or ...
If the fixes tags aren't there I will add them before I push them up.
In this case its
Fixes: 9fcf78cca198 ("apparmor: update domain transitions that are subsets of confinement at nnp")
> Regards,
> Markus
>
next prev parent reply other threads:[~2020-04-15 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 11:27 [PATCH v2] apparmor: fix potential label refcnt leak in aa_change_profile Markus Elfring
2020-04-15 18:41 ` John Johansen [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-05 5:11 Xiyu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5930264-946a-ad70-a327-62117499681b@canonical.com \
--to=john.johansen@canonical.com \
--cc=Markus.Elfring@web.de \
--cc=jmorris@namei.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=tanxin.ctf@gmail.com \
--cc=xiyuyang19@fudan.edu.cn \
--cc=yuanxzhang@fudan.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).