From: Jiele Zhao <unclexiaole@gmail.com>
To: serge@hallyn.com, jmorris@namei.org
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] integrity/ima: Add declarations to init_once void arguments.
Date: Tue, 6 Apr 2021 10:16:36 +0800 [thread overview]
Message-ID: <f97e397d-5d9f-31c3-c027-d9b89ba9637a@gmail.com> (raw)
In-Reply-To: <20210323013318.296993-1-unclexiaole@gmail.com>
Ping.
On 2021/3/23 9:33, Jiele Zhao wrote:
> init_once is a callback to kmem_cache_create. The parameter
> type of this function is void *, so it's better to give a
> explicit cast here.
>
> Signed-off-by: Jiele Zhao <unclexiaole@gmail.com>
> ---
> security/integrity/iint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 1d20003243c3..5f3f2de997e1 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -152,7 +152,7 @@ void integrity_inode_free(struct inode *inode)
>
> static void init_once(void *foo)
> {
> - struct integrity_iint_cache *iint = foo;
> + struct integrity_iint_cache *iint = (struct integrity_iint_cache *)foo;
>
> memset(iint, 0, sizeof(*iint));
> iint->ima_file_status = INTEGRITY_UNKNOWN;
next prev parent reply other threads:[~2021-04-06 2:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 1:33 [PATCH] integrity/ima: Add declarations to init_once void arguments Jiele Zhao
2021-03-29 10:18 ` Jiele Zhao
2021-04-06 2:16 ` Jiele Zhao [this message]
2021-04-06 2:38 ` James Morris
2021-04-06 6:24 ` Jiele Zhao
2021-04-06 12:46 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97e397d-5d9f-31c3-c027-d9b89ba9637a@gmail.com \
--to=unclexiaole@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).