linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Hyunki Koo" <hyunki00.koo@samsung.com>
To: "'Greg KH'" <gregkh@linuxfoundation.org>
Cc: <robh+dt@kernel.org>, <linux-serial@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver
Date: Mon, 27 Apr 2020 08:15:02 +0900	[thread overview]
Message-ID: <000001d61c20$837914d0$8a6b3e70$@samsung.com> (raw)
In-Reply-To: <20200424053711.GB103562@kroah.com>

On Fri, Apr 24, 2020 at 02:37:18PM +0900, Greg KH wrote:
> On Fri, Apr 24, 2020 at 09:40:18AM +0900, Hyunki Koo wrote:
> > On Sat, April 21, 2020 at 08:36:00 AM +0900, Hyunki Koo wrote:
> > >
> > > Change in v8:
> > > - spit into 3 patch
> > >   [1/3] create the new functions with no functional change to the
> > > code as- is.
> > >   Replace rd_regb/wr_regb with rd_reg/wr_reg for general usage.
> > >   [2/3] add the new binding reg-io-width in device tree
> > >   [3/3] add the new funtinality of rd_reg / wr_reg and wr_reg_barrier
> > >         to support 32-bit access for the TX/RX hold registers UTXH and
> URXH.
> > >
> > > Change in v7:
> > > - [1/2] correct build error on running 'make dt_binding_check'
> > > Documentation/devicetree/bindings/serial/samsung_uart.yaml:
> mapping
> > > values are not allowed in this context
> > >   in "<unicode string>", line 36, column 13
> > >   Documentation/devicetree/bindings/Makefile:12: recipe for target
> > >
> 'Documentation/devicetree/bindings/serial/samsung_uart.example.dts'
> > > failed
> > >   make[1]: ***
> > >
> [Documentation/devicetree/bindings/serial/samsung_uart.example.dts]
> > > Error 1
> > >   make[1]: *** Waiting for unfinished jobs....
> > >   Makefile:1262: recipe for target 'dt_binding_check' failed
> > >   make: *** [dt_binding_check] Error 2
> > > - [2/2] add commit message of reviewed by and tested by in commit
> > > message
> > >   Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> > >   Tested on Odroid HC1 (Exynos5422):
> > >   Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
> > >
> > > Change in v6:
> > > - [2/2] clean description of reg-io-width
> > >   allOf is not needed. Just enum [1, 2] is enough.
> > >
> > > Changes in v5:
> > > - spit into 2 patch, newly added patch for dt-binding
> > >   [1/2] newly added dt-binding and go as first patch in this series.
> > >   [2/2] go as second patch in this series.
> > >
> > > Changes in v4:
> > > - correct variable types and change misleading function name
> > >
> > > Changes in v3:
> > > - line 2031: remove redundant init value  for ourport->port.iotype
> > >
> > > Changes in v2:
> > > - line 954 : change rd_regl to rd_reg in for backward compatibility.
> > > - line 2031: Add init value for ourport->port.iotype  to UPIO_MEM
> > >
> > >
> > > Hyunki Koo (3):
> > >   serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg
> > >   dt-bindings: serial: Add reg-io-width compatible
> > >   tty: samsung_tty: 32-bit access for TX/RX hold registers
> > >
> > >  .../devicetree/bindings/serial/samsung_uart.yaml   |  8 +++
> > >  drivers/tty/serial/samsung_tty.c                   | 76
> ++++++++++++++++++---
> > > -
> > >  2 files changed, 72 insertions(+), 12 deletions(-)
> > >
> > > --
> > > 2.15.0.rc1
> >
> > Hi Greg KH
> >
> > Can I ask is this series patch are acceptable or not?
> > Do you think, I have to do any further action  for this patch?
> >
> 
> It's been 3 days, give us a chance please...
> 
> Also, I need to wait for the dt patch to be reviewed first before I can take
> any of this, so that's up to the DT maintainers.
> 
> thanks,
> 
> greg k-h

Sorry to disturb you and Thank you for your answer,
I will wait.


  reply	other threads:[~2020-04-26 23:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200420013322epcas2p263e72997dd4ebdaf00b095a83a6b6651@epcas2p2.samsung.com>
2020-04-20  1:32 ` [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Hyunki Koo
     [not found]   ` <CGME20200420013325epcas2p13f65e6bc8ba68f89c805704830144870@epcas2p1.samsung.com>
2020-04-20  1:32     ` [PATCH v8 2/3] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo
2020-04-30 15:12       ` Rob Herring
     [not found]   ` <CGME20200420013332epcas2p381793b8c09d71269d3e8c38a196a1c74@epcas2p3.samsung.com>
2020-04-20  1:32     ` [PATCH v8 3/3] tty: samsung_tty: 32-bit access for TX/RX hold registers Hyunki Koo
2020-04-20 14:19       ` Hyunki Koo
     [not found]   ` <CGME20200420233607epcas2p305dbd652ab73592a32c17773c1fce329@epcas2p3.samsung.com>
2020-04-20 23:35     ` [PATCH v8 0/3] 32-bit access for TX/RX hold registers for samsung_tty driver Hyunki Koo
2020-04-24  0:40       ` Hyunki Koo
2020-04-24  5:37         ` Greg KH
2020-04-26 23:15           ` Hyunki Koo [this message]
2020-05-05 14:23   ` [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr_reg Greg Kroah-Hartman
2020-05-05 23:30     ` Hyunki Koo
2020-05-06  6:31       ` 'Greg Kroah-Hartman'
2020-05-06  7:18         ` Hyunki Koo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000001d61c20$837914d0$8a6b3e70$@samsung.com' \
    --to=hyunki00.koo@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).