From: "Hyunki Koo" <hyunki00.koo@samsung.com>
To: "'Jiri Slaby'" <jslaby@suse.com>, <gregkh@linuxfoundation.org>,
<krzk@kernel.org>
Cc: "'Rob Herring'" <robh+dt@kernel.org>,
"'Kukjin Kim'" <kgene@kernel.org>, <linux-serial@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH v6 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers
Date: Tue, 7 Apr 2020 15:02:53 +0900 [thread overview]
Message-ID: <000401d60ca2$2d2b3550$87819ff0$@samsung.com> (raw)
In-Reply-To: <62a918df-b3ba-21f4-b3ad-9f638ad104ad@suse.com>
On 07. 04. 20, 1:49, Jiri Slaby wrote:
> On 07. 04. 20, 1:08, Hyunki Koo wrote:
> > Support 32-bit access for the TX/RX hold registers UTXH and URXH.
> >
> > This is required for some newer SoCs.
> >
> > Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> ...
> > ---
> > drivers/tty/serial/samsung_tty.c | 76
> > +++++++++++++++++++++++++++++++++-------
> > 1 file changed, 64 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c
> > b/drivers/tty/serial/samsung_tty.c
> > index 73f951d65b93..bdf1d4d12cb1 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > @@ -154,12 +154,47 @@ struct s3c24xx_uart_port {
> ...
> > -#define wr_regb(port, reg, val) writeb_relaxed(val, portaddr(port,
> > reg))
> > +static void wr_reg(struct uart_port *port, u32 reg, u32 val) {
> > + switch (port->iotype) {
> > + case UPIO_MEM:
> > + writeb_relaxed(val, portaddr(port, reg));
> > + break;
> > + case UPIO_MEM32:
> > + writel_relaxed(val, portaddr(port, reg));
> > + break;
> > + }
> > +}
> > +
> > #define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port,
> > reg))
> >
> > +static void wr_reg_barrier(struct uart_port *port, u32 reg, u32 val)
>
> You need to explain, why you need this _barrier variant now. This change
> should be done in a separate patch too.
>
> > +{
> > + switch (port->iotype) {
> > + case UPIO_MEM:
> > + writeb(val, portaddr(port, reg));
> > + break;
> > + case UPIO_MEM32:
> > + writel(val, portaddr(port, reg));
> > + break;
> > + }
> > +}
> > +
> > /* Byte-order aware bit setting/clearing functions. */
> >
> > static inline void s3c24xx_set_bit(struct uart_port *port, int idx,
>
> thanks,
> --
> js
> suse labs
The purpose of this patch is to support 32bit access for registers, and it is also working exsisting device.
There are 3 operations what I have to to change which are rd_regb, wr_regb, and writeb.
rd_regb, wr_regb are changed to rd_reg, wr_reg.
and writeb is changed to wr_reg_barrier.
So I make as a one patch.
wr_reg_barrier is not a different patch, itis just replaced from writeb.
next prev parent reply other threads:[~2020-04-07 6:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200401082749epcas2p2a774da515805bc3f761b6b5a8dc9e3d2@epcas2p2.samsung.com>
2020-04-01 8:27 ` [PATCH] tty: samsung_tty: 32-bit access for TX/RX hold registers Hyunki Koo
2020-04-01 8:55 ` Greg Kroah-Hartman
2020-04-01 9:19 ` Krzysztof Kozlowski
2020-04-02 9:44 ` Hyunki Koo
2020-04-02 9:48 ` 'Krzysztof Kozlowski'
[not found] ` <CGME20200402110609epcas2p4a5ec1fb3a5eaa3b12c20cfc2060162f3@epcas2p4.samsung.com>
2020-04-02 11:04 ` [PATCH v2] " Hyunki Koo
2020-04-02 12:18 ` Greg KH
2020-04-02 13:59 ` Krzysztof Kozlowski
2020-04-03 7:30 ` Hyunki Koo
2020-04-03 7:51 ` 'Krzysztof Kozlowski'
2020-04-03 10:19 ` Hyunki Koo
[not found] ` <CGME20200403102049epcas2p1d1fe95160b7f37609a8b1710c196cdd8@epcas2p1.samsung.com>
2020-04-03 10:20 ` [PATCH v3] " Hyunki Koo
2020-04-03 10:47 ` Krzysztof Kozlowski
2020-04-03 11:12 ` Hyunki Koo
2020-04-03 11:39 ` 'Krzysztof Kozlowski'
[not found] ` <CGME20200403111520epcas2p42ef81138693ffaaa281499c7a24e0e48@epcas2p4.samsung.com>
2020-04-03 11:15 ` [PATCH v4] " Hyunki Koo
2020-04-03 11:42 ` Greg KH
2020-04-03 11:53 ` Krzysztof Kozlowski
2020-04-03 11:57 ` Greg KH
2020-04-03 12:08 ` Krzysztof Kozlowski
2020-04-03 11:59 ` Krzysztof Kozlowski
2020-04-05 21:35 ` Hyunki Koo
2020-04-06 9:54 ` 'Krzysztof Kozlowski'
2020-04-03 13:34 ` Krzysztof Kozlowski
2020-04-05 21:41 ` Hyunki Koo
2020-04-06 9:53 ` 'Krzysztof Kozlowski'
[not found] ` <CGME20200406103158epcas2p2aaf3ef769a232dc28c04cb4ae91373bd@epcas2p2.samsung.com>
2020-04-06 10:31 ` [PATCH v5 2/2] " Hyunki Koo
[not found] ` <CGME20200406103206epcas2p2bf3c65f96d94cc91fcdcd3e6db75e2a3@epcas2p2.samsung.com>
2020-04-06 10:31 ` [PATCH v5 1/2] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo
2020-04-06 10:47 ` Krzysztof Kozlowski
2020-04-06 10:34 ` [PATCH v5 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers Krzysztof Kozlowski
[not found] ` <CGME20200406230902epcas2p19a8df6805dac59968d664efb9bc9419b@epcas2p1.samsung.com>
2020-04-06 23:08 ` [PATCH v6 " Hyunki Koo
[not found] ` <CGME20200406230906epcas2p3f5703f7f9f00cd1cf7dbe5cfd304481f@epcas2p3.samsung.com>
2020-04-06 23:08 ` [PATCH v6 1/2] dt-bindings: serial: Add reg-io-width compatible Hyunki Koo
2020-04-07 6:25 ` Krzysztof Kozlowski
2020-04-09 23:05 ` Rob Herring
2020-04-09 23:09 ` Rob Herring
2020-04-07 4:49 ` [PATCH v6 2/2] tty: samsung_tty: 32-bit access for TX/RX hold registers Jiri Slaby
2020-04-07 6:02 ` Hyunki Koo [this message]
2020-04-07 6:24 ` Krzysztof Kozlowski
2020-04-07 6:32 ` Jiri Slaby
2020-04-07 7:22 ` Krzysztof Kozlowski
2020-04-07 6:26 ` Krzysztof Kozlowski
2020-04-07 6:28 ` Jiri Slaby
2020-04-07 6:37 ` Jiri Slaby
2020-04-07 6:54 ` Hyunki Koo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000401d60ca2$2d2b3550$87819ff0$@samsung.com' \
--to=hyunki00.koo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).