From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C7DC38A29 for ; Fri, 17 Apr 2020 12:05:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92DC82083E for ; Fri, 17 Apr 2020 12:05:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="BVuAnuM1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727831AbgDQMFL (ORCPT ); Fri, 17 Apr 2020 08:05:11 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:61222 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727854AbgDQMFL (ORCPT ); Fri, 17 Apr 2020 08:05:11 -0400 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20200417120505epoutp02debe9c50653c0345d18be6ef24661a8b~Gmd-qfIE02283322833epoutp02h for ; Fri, 17 Apr 2020 12:05:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20200417120505epoutp02debe9c50653c0345d18be6ef24661a8b~Gmd-qfIE02283322833epoutp02h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1587125105; bh=dJcYkDnyAjd95+ohk9nQ0Dw6y/yaqHsf5/2UJiMepdc=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=BVuAnuM1mQf3WXaoZ/lgtlHItBeqQpkaRSb7gqtpDA5LgsnyyrO/iQ4ihYngX44zg qwIa4wu8HLKEW0KBmSvq4vT5D8A/P5CAJ+My0t9PgXWT+EeroHccYADjDDQElbRtS8 PfNyvRzaeUirAsal6mUpySJthFz4JJ9kKFknujH8= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20200417120505epcas2p42d385e6dc7da6ca2a4b235ca4b4c252f~Gmd-Mrf2n2738827388epcas2p4X; Fri, 17 Apr 2020 12:05:05 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.40.188]) by epsnrtp1.localdomain (Postfix) with ESMTP id 493ZXb130lzMqYlp; Fri, 17 Apr 2020 12:05:03 +0000 (GMT) Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id 53.EE.04393.F6B999E5; Fri, 17 Apr 2020 21:05:03 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p2.samsung.com (KnoxPortal) with ESMTPA id 20200417120502epcas2p2415cf80227a45ac7607c7df3de0058fc~Gmd87Fo9A0201902019epcas2p2A; Fri, 17 Apr 2020 12:05:02 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200417120502epsmtrp247085cffd8a424296475f9724ea02ce8~Gmd83jC0w1819518195epsmtrp2F; Fri, 17 Apr 2020 12:05:02 +0000 (GMT) X-AuditID: b6c32a47-667ff70000001129-9f-5e999b6f6c97 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 2B.49.04024.E6B999E5; Fri, 17 Apr 2020 21:05:02 +0900 (KST) Received: from KORCO004660 (unknown [12.36.165.196]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200417120502epsmtip233466db146fde9b7bc8b0ccc287e8101~Gmd8rXXZ01642516425epsmtip2i; Fri, 17 Apr 2020 12:05:02 +0000 (GMT) From: "Hyunki Koo" To: "'Greg KH'" , "'Hyunki Koo'" Cc: , , "'Kukjin Kim'" , "'Jiri Slaby'" , , , , , In-Reply-To: <20200416135618.GA1295013@kroah.com> Subject: RE: [PATCH v7 2/2] Support 32-bit access for the TX/RX hold registers UTXH and URXH. Date: Fri, 17 Apr 2020 21:05:02 +0900 Message-ID: <001501d614b0$6cab3ed0$4601bc70$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFi1K+6yj7qBWyiWiQvcgMo5OZtFgIiWQf+Anfu/XipPuQQEA== Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA02TWUwTURSGvZ12ZlCqY2U5VmPquCRg0BZsHVSMK9ZoDOqDxBjqBCZAnC7p FBV9UCibijuJMrgCoiEqWgoCCkSoUROFEAVFQ8IixiXuCkEj2HYw8vad5b9nufeSmKoBV5Op Fgdnt7A8jY+XVzeHMRHWosIEbWkrwVzwtCgYZ0kFzrRnfsaZgptfZMyxvg8Y09p6k2BcfR0K 5mndWZw509ogYx6XHCGY7HoPsXyCsVbsIoyu8oO4sfHcNcJYWbrfWOFulxu/u2bE4dv4pSkc m8TZNZwl0ZqUakmOoddvMa0y6Q1aXYQumllEayysmYuhV2+Ii4hN5b3t0ZpdLJ/mdcWxgkAv WLbUbk1zcJoUq+CIoTlbEm/T6WzzBdYspFmS5ydazYt1Wm2k3pu5g09p+vUV2boC94yM9KID aDDgEAoggVoIR347iUNoPKmiahAcvlKskIxvCHpu1cklYwDBYP5n2T9JV0YfJgXqEfzIOimT jHcIXt3Pwn1ZOBUBT0te+xVB1Fa4O+z0M0aVyKCqd6aPAygddD9sVPh4CmWC7ILrhI/l1Bz4 6TztZyUVDd2lbZjEk+FR4Wu5dM48KLv0AZM60sBQf5lCqrUSyls+juYEQdHBHH+nQOUS4D7q QZJgNTg78nGJp8D7B25CYjV8/1Q/6t8PDTknCEmcj2DoS79CCkSB+CbXexDprRAGFXULfAjU LPC8HK07EfKa/xCSWwl5OSpJOBduDLwdXeJ0uNZfRxxHtDhmMnHMZOKYCcT/tS4ieTkK4WyC OZkTIm1RY2/bhfxvN3xtDapu2dCEKBLRgcq8o4UJKgW7S0g3NyEgMTpIeS/W61Imsel7ObvV ZE/jOaEJ6b2LP4GpgxOt3p9gcZh0+kiDQRutZ/SGSIYOVbomdG5XUcmsg9vJcTbO/k8nIwPU B9CtzW29scNtxt2nTrnPhL6xW8KLK7+lFy/quTrpz+XA4TVFzttxNcYY8ZmHJ5c46rPK7k27 mJ25Ilc2yMdf2Pjxzt7qaeyz0EcFs1+8ddeOiyfYnOOV69p7nkyFzPP65+PuVtZeHagJUTNV /anWPZ3BvzaJ+zpk3RnN65obgy8ZxC20XEhhdeGYXWD/AvbPdJfRAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWy7bCSvG7e7JlxBksXqljMP3KO1aJ58Xo2 i6tN79kspmz4wGTR//g1s8X58xvYLTY9vsZqcXnXHDaLGef3MVmcWdzLbtG69wi7A7fHzll3 2T02repk89g/dw27x+Yl9R7rt1xl8fi8SS6ALYrLJiU1J7MstUjfLoErY/vzaewFV3gqzh7r ZmxgfMPZxcjJISFgInG38TFzFyMXh5DAbkaJs1cvskMkZCQmvFjCDGELS9xvOcIKUfScUeLz tqVgRWwCuhKXFz9hArFFBMIlFpw7BlbELLCaSeL75OVsEB2bGCVOL1/LClLFKWAo8eDEfjBb WCBW4uXzNrBuFgFVia/N08Gm8gpYSjxYcpEZwhaUODnzCQuIzSygLdH7sJURxl628DXUeQoS P58uY4W4wkli1bm3UPUiErM725gnMArPQjJqFpJRs5CMmoWkZQEjyypGydSC4tz03GLDAsO8 1HK94sTc4tK8dL3k/NxNjOAY1NLcwXh5SfwhRgEORiUeXoOemXFCrIllxZW5hxglOJiVRHgP ugGFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8z7NOxYpJJCeWJKanZpakFoEk2Xi4JRqYIx9d+za o8sdStdWZmpt8cnb/8KE1a4uzPVJc/OMlKb5R1fsWZq8QsHXdrfq/fk2DwydZ24rCrz+QUGF td5O/sWNReFPc6rCTuQlfkxZNjeU5++OlTHpRQZK5+xae00+MTOICU2ckh/+Y1rmK+2eju0L Mjb8K1TQeHbHP+phcFBb1uy48INKvUosxRmJhlrMRcWJAEHlfJ69AgAA X-CMS-MailID: 20200417120502epcas2p2415cf80227a45ac7607c7df3de0058fc X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20200416140255epcas2p2bf81ac129b7471eb1fe40e545dbd796d References: <20200411123325.30501-1-hyunki00.koo@gmail.com> <20200416135618.GA1295013@kroah.com> Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Apr 16, 2020 at 10:56:24PM +0900, Greg KH wrote: > On Sat, Apr 11, 2020 at 09:33:24PM +0900, Hyunki Koo wrote: > > From: Hyunki Koo > > > > This is required for some newer SoCs. > > > > Signed-off-by: Hyunki Koo > > Reviewed-by: Krzysztof Kozlowski Tested on Odroid > > HC1 (Exynos5422): > > Tested-by: Krzysztof Kozlowski > > --- > > v2: > > line 954 : change rd_regl to rd_reg in for backward compatibility. > > line 2031: Add init value for ourport->port.iotype to UPIO_MEM > > v3: > > line 2031: remove redundant init value for ourport->port.iotype > > v4: > > correct variable types and change misleading function name > > v5: > > add dt-binding and go as first patch in this series. > > v6: > > no change in this patch, only chaged in =5BPATCH v6 1/2=5D > > v7: > > add reviewed by and tested by > > --- >=20 > Your subject line changed for this and patch 2 :( >=20 > Also, I asked you to split this patch up better in the past, you seem to = have > ignored that :( >=20 > First patch would be to create the new functions and use them, with no > functional change to the code as-is. A second patch would add the new > binding, and a third patch would be to add the new functionality. >=20 > And you need to describe all of this very well in your changelog, the one > sentence here is not sufficient at all. >=20 > Please fix this all up and resend. >=20 > thanks, >=20 > greg k-h Sorry I missed your comment in V4, I will split and update the patch and re= -send.