From: Daniel Mack <daniel@zonque.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
gregkh@linuxfoundation.org, jslaby@suse.com,
pascal.huerst@gmail.com
Subject: Re: [PATCH 1/4] dt-bindings: sc16is7xx: Add flag to activate IrDA mode
Date: Mon, 18 May 2020 20:41:36 +0200 [thread overview]
Message-ID: <0494dbe1-81ad-493c-6eb0-a463a5604309@zonque.org> (raw)
In-Reply-To: <20200518180853.GA18566@bogus>
On 5/18/20 8:08 PM, Rob Herring wrote:
> On Fri, May 08, 2020 at 04:37:54PM +0200, Daniel Mack wrote:
>> From: Pascal Huerst <pascal.huerst@gmail.com>
>>
>> This series of uart controllers is able to work in IrDA mode.
>> This adds a flag to the device tree to enable that feature if needed.
>>
>> Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
>> ---
>> Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
>> index c1091a923a89..9317c320c82c 100644
>> --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
>> +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt
>> @@ -21,6 +21,8 @@ Optional properties:
>> the second cell is used to specify the GPIO polarity:
>> 0 = active high,
>> 1 = active low.
>> +- linux,irda-mode-port-0: Use IrDA mode on port #0
>> +- linux,irda-mode-port-1: Use IrDA mode on port #1 (for dual-port devices only)
>>
>> Example:
>> sc16is750: sc16is750@51 {
>> @@ -55,6 +57,8 @@ Optional properties:
>> the second cell is used to specify the GPIO polarity:
>> 0 = active high,
>> 1 = active low.
>> +- linux,irda-mode-port-0: Use IrDA mode on port #0
>> +- linux,irda-mode-port-1: Use IrDA mode on port #1 (for dual-port devices only)
>
> How about an array of 1 or 2 entries instead?
Yes, that would be an alternative. We just weren't sure what type the
elements of the array would have. Could you point to an existing example?
Thanks,
Daniel
next prev parent reply other threads:[~2020-05-18 18:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 14:37 [PATCH 0/4] sc16is7xx: Add IrDA mode and threaded IRQ Daniel Mack
2020-05-08 14:37 ` [PATCH 1/4] dt-bindings: sc16is7xx: Add flag to activate IrDA mode Daniel Mack
2020-05-18 18:08 ` Rob Herring
2020-05-18 18:41 ` Daniel Mack [this message]
2020-05-19 12:01 ` Maarten Brock
2020-05-08 14:37 ` [PATCH 2/4] " Daniel Mack
2020-05-08 14:37 ` [PATCH 3/4] sc16is7xx: Always use falling edge IRQ Daniel Mack
2020-05-09 12:41 ` Maarten Brock
2020-05-08 14:37 ` [PATCH 4/4] sc16is7xx: Use threaded IRQ Daniel Mack
2020-05-09 12:55 ` Maarten Brock
2020-05-17 20:44 ` Daniel Mack
2020-05-18 11:14 ` Maarten Brock
2020-05-18 16:57 ` Daniel Mack
2020-05-19 16:32 ` Maarten Brock
2020-05-19 17:37 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0494dbe1-81ad-493c-6eb0-a463a5604309@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-serial@vger.kernel.org \
--cc=pascal.huerst@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).