From: Maximilian Luz <luzmaximilian@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh@kernel.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Blaž Hrastnik" <blaz@mxxn.io>,
"Dorian Stoll" <dorian.stoll@tmsp.io>
Subject: Re: [RFC PATCH 5/9] surface_aggregator: Add error injection capabilities
Date: Wed, 23 Sep 2020 23:28:19 +0200 [thread overview]
Message-ID: <11657eb7-88a8-0c24-f7ee-fef9679c7837@gmail.com> (raw)
In-Reply-To: <20200923174543.GA102853@kroah.com>
On 9/23/20 7:45 PM, Greg Kroah-Hartman wrote:
> On Wed, Sep 23, 2020 at 05:15:07PM +0200, Maximilian Luz wrote:
>> This commit adds error injection hooks to the Surface Serial Hub
>> communication protocol implementation, to:
>>
>> - simulate simple serial transmission errors,
>>
>> - drop packets, requests, and responses, simulating communication
>> failures and potentially trigger retransmission timeouts, as well as
>>
>> - inject invalid data into submitted and received packets.
>>
>> Together with the trace points introduced in the previous commit, these
>> facilities are intended to aid in testing, validation, and debugging of
>> the Surface Aggregator communication layer.
>>
>> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
>
> Ok, this is ridiculous.
>
> You are dropping a whole new subsystem on us, with full documentation,
> correct driver model integration, crazy debugfs interactions (I made fun
> of the patch, but the code did work, you just did more work than was
> needed), proper auto-loading of modules, tracing, documentation for more
> things than is ever expected, and now you are adding error injection
> support?
>
> You just made all other code submissions of new subsystems I have gotten
> in the past 2 months look like total crud. Which, to be fair, they
> probably were, but wow, you just stepped up the level of professionalism
> to a whole new height.
>
> I can only dream that "real Linux companies" take note and try to follow
> this example. I think I will point them all at this in the future and
> say, "go do it like this one."
>
> very very very nice work, we owe you the beverage of your choice.
>
> greg k-h
Wow, thank you very much for those kind words! That means quite a lot to
me.
To be fair, I've been working on this whole project for about two years
now and a large part of the code has been rewritten in the last half a
year, specifically to get it ready for the kernel. So I guess that might
relativize things a bit :)
Thanks again,
Max
next prev parent reply other threads:[~2020-09-23 21:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 15:15 [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 2/9] surface_aggregator: Add control packet allocation chaching Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 3/9] surface_aggregator: Add event item " Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 4/9] surface_aggregator: Add trace points Maximilian Luz
2020-09-23 20:07 ` Steven Rostedt
2020-09-23 23:43 ` Maximilian Luz
2020-09-23 15:15 ` [RFC PATCH 5/9] surface_aggregator: Add error injection capabilities Maximilian Luz
2020-09-23 17:45 ` Greg Kroah-Hartman
2020-09-23 21:28 ` Maximilian Luz [this message]
2020-09-23 15:15 ` [RFC PATCH 7/9] docs: driver-api: Add Surface Aggregator subsystem documentation Maximilian Luz
2020-09-23 15:30 ` [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module Arnd Bergmann
2020-09-23 15:43 ` Maximilian Luz
2020-09-23 19:43 ` Arnd Bergmann
2020-09-23 23:28 ` Maximilian Luz
2020-09-24 8:26 ` Arnd Bergmann
2020-09-24 18:59 ` Maximilian Luz
2020-09-24 19:38 ` Arnd Bergmann
2020-09-24 21:07 ` Maximilian Luz
2020-09-25 14:53 ` Andy Shevchenko
2020-09-24 8:30 ` Andy Shevchenko
2020-09-24 19:17 ` Maximilian Luz
2020-09-25 14:58 ` Andy Shevchenko
2020-09-25 15:41 ` Maximilian Luz
[not found] ` <20200923151511.3842150-2-luzmaximilian@gmail.com>
2020-09-23 16:57 ` [RFC PATCH 1/9] misc: Add Surface Aggregator subsystem Greg Kroah-Hartman
2020-09-23 20:34 ` Maximilian Luz
2020-09-24 6:48 ` Greg Kroah-Hartman
2020-09-24 18:16 ` Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11657eb7-88a8-0c24-f7ee-fef9679c7837@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=arnd@arndb.de \
--cc=blaz@mxxn.io \
--cc=dorian.stoll@tmsp.io \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).