From: Rob Herring <robh@kernel.org>
To: Erwan Le Ray <erwan.leray@st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-serial@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Fabrice Gasnier <fabrice.gasnier@st.com>,
Bich Hemon <bich.hemon@st.com>
Subject: Re: [PATCH v3 02/10] dt-bindings: serial: add optional pinctrl states
Date: Tue, 9 Jul 2019 08:38:38 -0600 [thread overview]
Message-ID: <20190709143838.GA5665@bogus> (raw)
In-Reply-To: <1560433800-12255-3-git-send-email-erwan.leray@st.com>
On Thu, Jun 13, 2019 at 03:49:52PM +0200, Erwan Le Ray wrote:
> From: Bich Hemon <bich.hemon@st.com>
>
> Add options for pinctrl states:
> - "sleep" for low power
> - "idle" for low power and wakeup capabilities enabled
> - "no_console_suspend" for enabling console messages in low power
>
> Signed-off-by: Bich Hemon <bich.hemon@st.com>
> Signed-off-by: Erwan Le Ray <erwan.leray@st.com>
>
> diff --git a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> index 5ec80c1..64a5ea9 100644
> --- a/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> +++ b/Documentation/devicetree/bindings/serial/st,stm32-usart.txt
> @@ -13,7 +13,14 @@ Required properties:
> - clocks: The input clock of the USART instance
>
> Optional properties:
> -- pinctrl: The reference on the pins configuration
> +- pinctrl-names: Set to "default". An additional "sleep" state can be defined
> + to set pins in sleep state when in low power. In case the device is used as
> + a wakeup source, "idle" state is defined in order to keep RX pin active.
> + For a console device, an optional state "no_console_suspend" can be defined
> + to enable console messages during suspend. Typically, "no_console_suspend" and
> + "default" states can refer to the same pin configuration.
no_console_suspend is a linux thing and doesn't belong in DT.
Rob
next prev parent reply other threads:[~2019-07-09 14:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 13:49 [PATCH v3 00/10] STM32 usart power improvements Erwan Le Ray
2019-06-13 13:49 ` [PATCH v3 01/10] dt-bindings: serial: stm32: add wakeup option Erwan Le Ray
2019-07-09 14:35 ` Rob Herring
2019-06-13 13:49 ` [PATCH v3 02/10] dt-bindings: serial: add optional pinctrl states Erwan Le Ray
2019-07-09 14:38 ` Rob Herring [this message]
2019-06-13 13:49 ` [PATCH v3 03/10] serial: stm32: select pinctrl state in each suspend/resume function Erwan Le Ray
2019-06-13 13:49 ` [PATCH v3 04/10] serial: stm32: add pm_runtime support Erwan Le Ray
2019-06-13 13:49 ` [PATCH v3 05/10] serial: stm32: Use __maybe_unused instead of #if CONFIG_PM_SLEEP Erwan Le Ray
2019-06-13 13:49 ` [PATCH v3 06/10] serial: stm32: add support for no_console_suspend Erwan Le Ray
2019-06-13 13:49 ` [PATCH v3 07/10] ARM: dts: stm32: update uart4 pin configurations for low power Erwan Le Ray
2019-06-13 13:49 ` [PATCH v3 08/10] ARM: dts: stm32: Update pin states for uart4 on stm32mp157c-ed1 Erwan Le Ray
2019-06-13 13:49 ` [PATCH v3 09/10] ARM: dts: stm32: Update UART4 pin states on stm32mp157a-dk1 Erwan Le Ray
2019-06-13 13:50 ` [PATCH v3 10/10] ARM: dts: stm32: add wakeup capability on each usart/uart on stm32mp157c Erwan Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709143838.GA5665@bogus \
--to=robh@kernel.org \
--cc=alexandre.torgue@st.com \
--cc=bich.hemon@st.com \
--cc=devicetree@vger.kernel.org \
--cc=erwan.leray@st.com \
--cc=fabrice.gasnier@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).