linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "jslaby@suse.com" <jslaby@suse.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"festevam@gmail.com" <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andy Duan <fugang.duan@nxp.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH V2] tty: serial: fsl_lpuart: use the sg count from dma_map_sg
Date: Thu, 7 Nov 2019 08:02:29 +0100	[thread overview]
Message-ID: <20191107070229.GA1114824@kroah.com> (raw)
In-Reply-To: <1573094911-448-1-git-send-email-peng.fan@nxp.com>

On Thu, Nov 07, 2019 at 02:50:11AM +0000, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The dmaengine_prep_slave_sg needs to use sg count returned
> by dma_map_sg, not use sport->dma_tx_nents, because the return
> value of dma_map_sg is not always same with "nents".
> 
> When enabling iommu for lpuart + edma, iommu framework may concatenate
> two sgs into one.
> 
> Fixes: 6250cc30c4c4e ("tty: serial: fsl_lpuart: Use scatter/gather DMA for Tx")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> V2:
>  Assign ret to sport->dma_tx_nents, then we no need to fix dma_unmap_sg
>  Hi Greg,
>   I saw v1 patch merged to tty-next, please help to replace with V2 if this
>   is ok for you, or you need I have a follow up fix for v1.

I can not "replace" anything, my tree does not rebase, sorry.  Please
send fix-up patches on top of it if there is any changes that need to
happen.

thanks,

greg k-h

      parent reply	other threads:[~2019-11-07  7:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  2:50 [PATCH V2] tty: serial: fsl_lpuart: use the sg count from dma_map_sg Peng Fan
2019-11-07  6:36 ` Peng Fan
2019-11-07  7:02 ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191107070229.GA1114824@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@nxp.com \
    --cc=jslaby@suse.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).