From: Greg KH <gregkh@linuxfoundation.org>
To: Johan Hovold <johan@kernel.org>
Cc: shubhrajyoti.datta@gmail.com, linux-serial@vger.kernel.org,
jacmet@sunsite.dk, git@xilinx.com,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCHv5] serial-uartlite: Remove ULITE_NR_PORTS macro
Date: Thu, 14 Nov 2019 06:26:02 +0800 [thread overview]
Message-ID: <20191113222602.GA5302@kroah.com> (raw)
In-Reply-To: <20191113153846.GW11035@localhost>
On Wed, Nov 13, 2019 at 04:38:46PM +0100, Johan Hovold wrote:
> On Wed, Nov 13, 2019 at 12:00:08PM +0000, shubhrajyoti.datta@gmail.com wrote:
> > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> >
> > This patch is removing ULITE_NR_PORTS macro which limits number of
> > ports which can be used. Every instance is registering own struct
> > uart_driver with minor number which corresponds to alias ID (or 0 now).
> > and with 1 uart port. The same alias ID is saved to
> > tty_driver->name_base which is key field for creating ttyULX name.
> >
> > Because name_base and minor number are setup already there is no need to
> > setup any port->line number because 0 is the right value.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > ---
> > v4: patch addition
> > v5: Merge the patch so that all the patches compile
>
> Greg,
>
> Please do not merge this. This is a hack which really needs to be
> reconsidered as I've pointed before
>
> https://lkml.kernel.org/r/20190523091839.GC568@localhost
>
> I suggest you also drop the first two patches that you applied to
> tty-testing earlier today.
Oops, my fault, will go drop all of these, thanks.
> Shubhrajyoti, please keep on CC with these changes. I'll try to review
> this again and get back to you shortly.
I think we should also revert all the previous changes as well, as you
have pointed out. This driver needs a good overhaul, but not in this
way :(
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-13 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:00 [PATCHv5] serial-uartlite: Remove ULITE_NR_PORTS macro shubhrajyoti.datta
2019-11-13 15:38 ` Johan Hovold
2019-11-13 22:26 ` Greg KH [this message]
2019-11-15 8:21 ` Michal Simek
2019-11-25 13:08 ` Michal Simek
2019-12-03 15:27 ` Johan Hovold
2019-12-12 10:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113222602.GA5302@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=git@xilinx.com \
--cc=jacmet@sunsite.dk \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).