linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Akash Asthana <akashast@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
	mgautam@codeaurora.org, swboyd@chromium.org,
	msavaliy@codeaurora.org
Subject: Re: [PATCH v5 1/3] tty: serial: qcom_geni_serial: IRQ cleanup
Date: Fri, 15 Nov 2019 12:52:40 +0800	[thread overview]
Message-ID: <20191115045240.GA799309@kroah.com> (raw)
In-Reply-To: <8aacf270-7e0f-8f8f-aac6-4cdaf6d3fd21@codeaurora.org>

On Fri, Nov 15, 2019 at 10:11:40AM +0530, Akash Asthana wrote:
> 
> On 11/13/2019 4:26 PM, Greg KH wrote:
> > On Wed, Nov 13, 2019 at 04:18:31PM +0530, Akash Asthana wrote:
> > > Move ISR registration from startup to probe function to avoid registering
> > > it everytime when the port open is called for driver.
> > > 
> > > Signed-off-by: Akash Asthana <akashast@codeaurora.org>
> > > ---
> > > Changes in v5:
> > >   - No change.
> > This series does not apply at all to my tty-next branch of my tty git
> > tree.  What did you make it against?  Please rebase it and resend so
> > that it can be applied.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Please revert below 2 commits and apply the patches in series.
> 
> 1) 8b7103f31950443fd5727d7d80d3c65416b5a390   (v2 patch)
> 
> 2) 3e4aaea7a0391d47f6ffff1f10594c658a67c881 (v2 patch)
> 
> I have verified the same on tty-next branch, it's applying cleanly.

Can you please send me a series that does the revert and then has your
new patches?  Or change your patches to work cleanly on the tty-next
branch, I don't want to have to do reverts "by hand" like this.

Also, how in the world was I supposed to know to do this?  Please be
considerate of maintainers, we are overworked as it is...

thanks,

greg k-h

  reply	other threads:[~2019-11-15  4:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 10:48 [PATCH v5 1/3] tty: serial: qcom_geni_serial: IRQ cleanup Akash Asthana
2019-11-13 10:56 ` Greg KH
2019-11-15  4:41   ` Akash Asthana
2019-11-15  4:52     ` Greg KH [this message]
2019-11-15  4:59       ` Akash Asthana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115045240.GA799309@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akashast@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mgautam@codeaurora.org \
    --cc=msavaliy@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).