From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02F4FC432C0 for ; Wed, 20 Nov 2019 19:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB20220898 for ; Wed, 20 Nov 2019 19:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574278011; bh=888qcNglt2aTTLwRLbfmkuf5RTUPH/vN/mvNViLPEiU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=YvhErG003CSmn6sqY7AgsVFSAj3/8ZtyBHcbHO1BGV6tJTwgTkNdldrJgjIwwRcwY 0WdHif0Mj5k6kg0M39BBbWelnAPomwKOIl1PG+sb7OZI78fShg7ZPpkgemZBfFcW+6 WRn2rl9vQLIMSsSb3D0NpeP+tvSYTty756uaQ4T4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727385AbfKTT0v (ORCPT ); Wed, 20 Nov 2019 14:26:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:59934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727582AbfKTT0v (ORCPT ); Wed, 20 Nov 2019 14:26:51 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF3FC20715; Wed, 20 Nov 2019 19:26:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574278010; bh=888qcNglt2aTTLwRLbfmkuf5RTUPH/vN/mvNViLPEiU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qKUolow49rTYCuaqW/HzuQAs4Vg7WSbifWby4JjUoi0Or7N8DDNZkdmk4g9956COv CpjE0MSqZK+GWUnI7iPlhI2DF+XaKdOsDIGdK7+T1+WcFtaiAaAVF0qi87dhpTvrWg dz9CzAS+fK97+U2w6Gn5+TV720gK0+C77qDyjKqk= Date: Wed, 20 Nov 2019 20:26:48 +0100 From: Greg Kroah-Hartman To: Mateusz Holenko Cc: Rob Herring , Mark Rutland , Jiri Slaby , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, Stafford Horne , Karol Gugala , Mauro Carvalho Chehab , "David S. Miller" , "Paul E. McKenney" , Filip Kokosinski , Joel Stanley , Jonathan Cameron , Maxime Ripard , Shawn Guo , Heiko Stuebner , Sam Ravnborg , Icenowy Zheng , Laurent Pinchart , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] litex: add common LiteX header Message-ID: <20191120192648.GA3087498@kroah.com> References: <20191023114634.13657-0-mholenko@antmicro.com> <20191023114634.13657-2-mholenko@antmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023114634.13657-2-mholenko@antmicro.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, Oct 23, 2019 at 11:47:04AM +0200, Mateusz Holenko wrote: > +#ifdef __LITTLE_ENDIAN > +# define LITEX_READ_REG(addr) ioread32(addr) > +# define LITEX_READ_REG_OFF(addr, off) ioread32(addr + off) > +# define LITEX_WRITE_REG(val, addr) iowrite32(val, addr) > +# define LITEX_WRITE_REG_OFF(val, addr, off) iowrite32(val, addr + off) > +#else > +# define LITEX_READ_REG(addr) ioread32be(addr) > +# define LITEX_READ_REG_OFF(addr, off) ioread32be(addr + off) > +# define LITEX_WRITE_REG(val, addr) iowrite32be(val, addr) > +# define LITEX_WRITE_REG_OFF(val, addr, off) iowrite32be(val, addr + off) > +#endif I just noticed this. Ick, this is not good. You will run into problems in the future with this, I can guarantee it. What about systems where the CPU is one endian and the hardware in the other? It will happen trust us. Make these real functions (inline is nice) and pass in the pointer to the device so you can test for it and call the correct function based on the cpu/hardware type. And what about bitfields? What endian are they for your system/hardware? Almost no kernel code should EVER be testing __LITTLE_ENDIAN, don't add to it as it is not a good idea. thanks, greg k-h