From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DATE_IN_PAST_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9928AC43603 for ; Fri, 13 Dec 2019 21:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5453B2465A for ; Fri, 13 Dec 2019 21:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576273734; bh=W6PNMUKclSNiyukyuEfFoNLFmNoXI+aexIYgZ4MTdjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Tvg0g42+KXGtoum0Raz0RA9OaLoA9TTqD/7oPTGw4G3pT+uoKFQAw/F2r8LAHFC/q 8AyaXb8H/4OOHQB71pduZqPbnBZrxsDakUjzGwynWGe0PdgOieoc+htdmOYNxmgIA7 KrFfYHuwRqILPzB413y3rJDDb8rL/tLQt8MFgO0o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbfLMVsw (ORCPT ); Fri, 13 Dec 2019 16:48:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:52642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbfLMVsw (ORCPT ); Fri, 13 Dec 2019 16:48:52 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E51772465A; Fri, 13 Dec 2019 21:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576273731; bh=W6PNMUKclSNiyukyuEfFoNLFmNoXI+aexIYgZ4MTdjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PeEofRhsCvjZ+oPbAqR3cXLYfTQrMxwVJwTPrn2WP14QZe/PuCvRGUlRXNDZ6L22p UNxVsIZmRGhOh7RIjhSqn/YG+VgeeZM0YsLYAovRdNf5reI1pvJr3oq5XoxQmmHWrg Yf7uhsv8CrEa5gmU7TN4t3Be9otvEyQCgL+krue4= Date: Fri, 13 Dec 2019 17:07:26 +0100 From: Greg KH To: David Engraf Cc: richard.genoud@gmail.com, jslaby@suse.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider handling Message-ID: <20191213160726.GB2632926@kroah.com> References: <1e2e3f63-84db-4b38-1bf1-85916116e0a2@sysgo.com> <20191213140301.16490-1-david.engraf@sysgo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191213140301.16490-1-david.engraf@sysgo.com> Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Dec 13, 2019 at 03:03:01PM +0100, David Engraf wrote: > Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode > register was already written thus the clock selection is ignored. > > Fix by doing the baud rate calulation before setting the mode. > > Fixes: 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support") > Signed-off-by: David Engraf > --- > drivers/tty/serial/atmel_serial.c | 43 ++++++++++++++++--------------- > 1 file changed, 22 insertions(+), 21 deletions(-) What changed from v1? Always put that below the --- line. v3 please? thanks, greg k-h