From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
linux-serial@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 1/3] tty: new helper function tty_kopen_shared
Date: Tue, 17 Dec 2019 09:27:33 +0100 [thread overview]
Message-ID: <20191217082733.GA2672708@kroah.com> (raw)
In-Reply-To: <20191217081718.23807-2-u.kleine-koenig@pengutronix.de>
On Tue, Dec 17, 2019 at 09:17:16AM +0100, Uwe Kleine-König wrote:
> This function gives a struct tty_struct for a given device number.
That says _what_ this does, but not why :)
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/tty/tty_io.c | 27 +++++++++++++++++++++++++++
> include/linux/tty.h | 1 +
> 2 files changed, 28 insertions(+)
>
> diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
> index d9f54c7d94f2..584025117cd3 100644
> --- a/drivers/tty/tty_io.c
> +++ b/drivers/tty/tty_io.c
> @@ -1925,6 +1925,33 @@ struct tty_struct *tty_kopen(dev_t device)
> }
> EXPORT_SYMBOL_GPL(tty_kopen);
>
> +/*
> + * Caller gets a reference on (non-error) ttys, that must be disposed using
> + * tty_kref_put().
> + */
It's a global function, can you please use kerneldoc?
And please describe it as well as tty_kopen() is.
> +struct tty_struct *tty_kopen_shared(dev_t device)
> +{
> + struct tty_struct *tty;
> + struct tty_driver *driver;
> + int index = -1;
> +
> + mutex_lock(&tty_mutex);
> + driver = tty_lookup_driver(device, NULL, &index);
> + if (IS_ERR(driver)) {
> + tty = ERR_CAST(driver);
> + goto err_lookup_driver;
> + }
> +
> + tty = tty_driver_lookup_tty(driver, NULL, index);
No error check?
> +
> + tty_driver_kref_put(driver);
> +err_lookup_driver:
> +
> + mutex_unlock(&tty_mutex);
> + return tty;
Can't you share a lot of this code with tty_kopen()? It feels odd to
duplicatate _almost_ all of it here.
> +}
> +EXPORT_SYMBOL(tty_kopen_shared);
EXPORT_SYMBOL_GPL() please.
thanks,
greg k-h
next prev parent reply other threads:[~2019-12-17 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 8:17 [PATCH v2 0/3] tty/leds: implement a trigger for ttys Uwe Kleine-König
2019-12-17 8:17 ` [PATCH v2 1/3] tty: new helper function tty_kopen_shared Uwe Kleine-König
2019-12-17 8:27 ` Greg Kroah-Hartman [this message]
2019-12-17 10:51 ` Uwe Kleine-König
2019-12-17 11:05 ` Greg Kroah-Hartman
2019-12-17 8:17 ` [PATCH v2 2/3] tty: new helper function tty_get_icount() Uwe Kleine-König
2019-12-17 8:28 ` Greg Kroah-Hartman
2019-12-17 8:17 ` [PATCH v2 3/3] leds: trigger: implement a tty trigger Uwe Kleine-König
2019-12-17 8:32 ` Greg Kroah-Hartman
2019-12-17 10:58 ` Uwe Kleine-König
2019-12-17 11:07 ` Greg Kroah-Hartman
2019-12-17 8:32 ` [PATCH v2 0/3] tty/leds: implement a trigger for ttys Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217082733.GA2672708@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).