* [PATCH] Revert "serdev: simplify Makefile"
@ 2019-12-18 13:11 Johan Hovold
2019-12-18 14:00 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2019-12-18 13:11 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Uwe Kleine-König, Rob Herring, Jiri Slaby, linux-serial,
linux-kernel, Johan Hovold, kbuild test robot
This reverts commit 54edb425346a4d5e17f7e54e8c97c0d0eac26315.
The offending commit caused serdev core to always be built-in, something
which breaks the build of dependent modules when serdev is being built
as a module:
ERROR: "__serdev_device_driver_register" [drivers/gnss/gnss-ubx.ko] undefined!
...
make[2]: *** [/home/johan/work/omicron/src/linux/scripts/Makefile.modpost:94: __modpost] Error 1
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/tty/serdev/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serdev/Makefile b/drivers/tty/serdev/Makefile
index f71bb931735b..078417e5b068 100644
--- a/drivers/tty/serdev/Makefile
+++ b/drivers/tty/serdev/Makefile
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0
serdev-objs := core.o
-obj-y += serdev.o
+obj-$(CONFIG_SERIAL_DEV_BUS) += serdev.o
obj-$(CONFIG_SERIAL_DEV_CTRL_TTYPORT) += serdev-ttyport.o
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "serdev: simplify Makefile"
2019-12-18 13:11 [PATCH] Revert "serdev: simplify Makefile" Johan Hovold
@ 2019-12-18 14:00 ` Greg Kroah-Hartman
2019-12-18 16:33 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-12-18 14:00 UTC (permalink / raw)
To: Johan Hovold
Cc: Uwe Kleine-König, Rob Herring, Jiri Slaby, linux-serial,
linux-kernel, kbuild test robot
On Wed, Dec 18, 2019 at 02:11:54PM +0100, Johan Hovold wrote:
> This reverts commit 54edb425346a4d5e17f7e54e8c97c0d0eac26315.
>
> The offending commit caused serdev core to always be built-in, something
> which breaks the build of dependent modules when serdev is being built
> as a module:
>
> ERROR: "__serdev_device_driver_register" [drivers/gnss/gnss-ubx.ko] undefined!
> ...
> make[2]: *** [/home/johan/work/omicron/src/linux/scripts/Makefile.modpost:94: __modpost] Error 1
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/tty/serdev/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Heh, give me a chance to catch up here, I would have reverted it on my
own :)
I'll go queue this up now, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "serdev: simplify Makefile"
2019-12-18 14:00 ` Greg Kroah-Hartman
@ 2019-12-18 16:33 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2019-12-18 16:33 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Johan Hovold, Uwe Kleine-König, Rob Herring, Jiri Slaby,
linux-serial, linux-kernel, kbuild test robot
On Wed, Dec 18, 2019 at 03:00:16PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Dec 18, 2019 at 02:11:54PM +0100, Johan Hovold wrote:
> > This reverts commit 54edb425346a4d5e17f7e54e8c97c0d0eac26315.
> >
> > The offending commit caused serdev core to always be built-in, something
> > which breaks the build of dependent modules when serdev is being built
> > as a module:
> >
> > ERROR: "__serdev_device_driver_register" [drivers/gnss/gnss-ubx.ko] undefined!
> > ...
> > make[2]: *** [/home/johan/work/omicron/src/linux/scripts/Makefile.modpost:94: __modpost] Error 1
> >
> > Reported-by: kbuild test robot <lkp@intel.com>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > drivers/tty/serdev/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Heh, give me a chance to catch up here, I would have reverted it on my
> own :)
Heh, good. :)
> I'll go queue this up now, thanks.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-18 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-18 13:11 [PATCH] Revert "serdev: simplify Makefile" Johan Hovold
2019-12-18 14:00 ` Greg Kroah-Hartman
2019-12-18 16:33 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).