From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3E1C2D0C0 for ; Mon, 23 Dec 2019 12:06:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 098A12073A for ; Mon, 23 Dec 2019 12:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577102814; bh=UJGipIs3R0eAFs/+vxP9hO/yM5VYdXO2adysSDweAhc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dKnD6h6b80HWzPvaRPiXZ5LtYnj5V4H0UsKr+rhTA0MIANEablVk2jjofADghM4v7 ZAppTT6yeg78FS6maN8c7igT5jmi4rZIJCVKgBuAYlVyF/Bncr/CUgngKj87Hzqui6 JtRIj8uf7tqGqmsSw8DFAYEEJieOYpMQ1hs6SJM8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbfLWMGx (ORCPT ); Mon, 23 Dec 2019 07:06:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:37958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbfLWMGx (ORCPT ); Mon, 23 Dec 2019 07:06:53 -0500 Received: from localhost (50-198-241-253-static.hfc.comcastbusiness.net [50.198.241.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 963112063A; Mon, 23 Dec 2019 12:06:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577102812; bh=UJGipIs3R0eAFs/+vxP9hO/yM5VYdXO2adysSDweAhc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fz2yc8cDetWe4VFTEb9zU418nJ8+h2ixEHwK4M1+tCvv5q0EELvft/sEOBf9OgdBR g0fKDmEZbkFl2tFeMH9BQ1G7px1JKNKQDztlyAmvqszPwo/LkD3g/nqrzqTVfXE/rK hrYisPKy4oJF9GfEm80pUeULbSfvMr+fxK55XIWY= Date: Mon, 23 Dec 2019 07:06:51 -0500 From: Greg KH To: Linus Torvalds Cc: Sudip Mukherjee , Jiri Slaby , Stephen Rothwell , Andrew Morton , Linux Kernel Mailing List , linux-serial@vger.kernel.org Subject: Re: [GIT PULL] TTY/Serial driver fixes for 5.5-rc3 Message-ID: <20191223120651.GC114474@kroah.com> References: <20191220070747.GA2190169@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Fri, Dec 20, 2019 at 10:08:03AM -0800, Linus Torvalds wrote: > On Thu, Dec 19, 2019 at 11:07 PM Greg KH wrote: > > > > The last tty core fix should resolve a long-standing bug with a race > > at port creation time that some people would see, and Sudip finally > > tracked down. > > Hmm, looks good. But it makes me wonder if we should now try to remove > the second call to tty_port_link_device()? > > Now we have a number of helpers that do that tty_port_link_device() > call for the driver (eg tty_port_register_device_attr_serdev(), > tty_port_register_device_attr(), and the just added > uart_add_one_port()). > > But we also have drivers doing it by hand, and presumably we now have > drivers that do it through multiple paths? I guess it's harmless, but > it feels a bit odd. No? It does. I'll try to look at this after the holidays unless Sudip beats me to it. thanks, greg k-h