From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Sergey Organov <sorganov@gmail.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] usb: gadget: serial: fix Tx stall after buffer overflow
Date: Tue, 21 Jan 2020 17:39:30 +0100 [thread overview]
Message-ID: <20200121163930.GA30699@qmqm.qmqm.pl> (raw)
In-Reply-To: <87a76hh13r.fsf@osv.gnss.ru>
On Tue, Jan 21, 2020 at 07:42:16AM +0300, Sergey Organov wrote:
> Symptom: application opens /dev/ttyGS0 and starts sending (writing) to
> it while either USB cable is not connected, or nobody listens on the
> other side of the cable. If driver circular buffer overflows before
> connection is established, no data will be written to the USB layer
> until/unless /dev/ttyGS0 is closed and re-opened again by the
> application (the latter besides having no means of being notified about
> the event of establishing of the connection.)
>
> Fix: on open and/or connect, kick Tx to flush circular buffer data to
> USB layer.
>
> Signed-off-by: Sergey Organov <sorganov@gmail.com>
> ---
>
> Changes in v2:
>
> - Add comment to document why tty_wakeup() is kept in place
> - Don't add debug print
> - Remove NOTE from description
Reviewed-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Best Regards,
Michał Mirosław
next prev parent reply other threads:[~2020-01-21 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 5:29 [PATCH] usb: gadget: serial: fix Tx stall after buffer overflow Sergey Organov
2020-01-17 20:34 ` Michał Mirosław
2020-01-20 6:06 ` Sergey Organov
2020-01-20 9:45 ` Michał Mirosław
2020-01-20 13:38 ` Sergey Organov
2020-01-20 14:05 ` Michał Mirosław
2020-01-21 6:41 ` Sergey Organov
2020-01-21 4:42 ` [PATCH v2] " Sergey Organov
2020-01-21 16:39 ` Michał Mirosław [this message]
2020-01-29 11:21 ` [PATCH v3] " Sergey Organov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121163930.GA30699@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sorganov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).