Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] serial: 8250_ioc3: Fix ioremap call
@ 2020-02-04 11:39 Thomas Bogendoerfer
  2020-02-04 14:39 ` Andy Shevchenko
  2020-02-10 19:33 ` Greg Kroah-Hartman
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2020-02-04 11:39 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Jiri Slaby, Paul Burton, linux-serial, linux-kernel

Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
time. So fix 8250_ioc3 by using devm_ioremap.

Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
 drivers/tty/serial/8250/8250_ioc3.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
index 4c405f1b9c67..d5a39e105a76 100644
--- a/drivers/tty/serial/8250/8250_ioc3.c
+++ b/drivers/tty/serial/8250/8250_ioc3.c
@@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
 	if (!data)
 		return -ENOMEM;
 
-	membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
+	membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
 	if (!membase)
 		return -ENOMEM;
 
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] serial: 8250_ioc3: Fix ioremap call
  2020-02-04 11:39 [PATCH] serial: 8250_ioc3: Fix ioremap call Thomas Bogendoerfer
@ 2020-02-04 14:39 ` Andy Shevchenko
  2020-02-10 19:33 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-02-04 14:39 UTC (permalink / raw)
  To: Thomas Bogendoerfer
  Cc: Greg Kroah-Hartman, Jiri Slaby, Paul Burton,
	open list:SERIAL DRIVERS, Linux Kernel Mailing List

On Tue, Feb 4, 2020 at 1:40 PM Thomas Bogendoerfer
<tbogendoerfer@suse.de> wrote:
>
> Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
> time. So fix 8250_ioc3 by using devm_ioremap.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")

Basically it happened due to ioremap_nocache() removal, but it really
doesn't matter because in this case no functional change is expected.

> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
>  drivers/tty/serial/8250/8250_ioc3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
> index 4c405f1b9c67..d5a39e105a76 100644
> --- a/drivers/tty/serial/8250/8250_ioc3.c
> +++ b/drivers/tty/serial/8250/8250_ioc3.c
> @@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
>         if (!data)
>                 return -ENOMEM;
>
> -       membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
> +       membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
>         if (!membase)
>                 return -ENOMEM;
>
> --
> 2.24.1
>


-- 
With Best Regards,
Andy Shevchenko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] serial: 8250_ioc3: Fix ioremap call
  2020-02-04 11:39 [PATCH] serial: 8250_ioc3: Fix ioremap call Thomas Bogendoerfer
  2020-02-04 14:39 ` Andy Shevchenko
@ 2020-02-10 19:33 ` Greg Kroah-Hartman
  1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-02-10 19:33 UTC (permalink / raw)
  To: Thomas Bogendoerfer; +Cc: Jiri Slaby, Paul Burton, linux-serial, linux-kernel

On Tue, Feb 04, 2020 at 12:39:12PM +0100, Thomas Bogendoerfer wrote:
> Commit 4bdc0d676a64 ("remove ioremap_nocache and devm_ioremap_nocache")
> removed devm_ioremap_nocache, but 8250_ioc3 wasn't upstream at that
> time. So fix 8250_ioc3 by using devm_ioremap.
> 
> Fixes: 0ce5ebd24d25 ("mfd: ioc3: Add driver for SGI IOC3 chip")
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
> ---
>  drivers/tty/serial/8250/8250_ioc3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_ioc3.c b/drivers/tty/serial/8250/8250_ioc3.c
> index 4c405f1b9c67..d5a39e105a76 100644
> --- a/drivers/tty/serial/8250/8250_ioc3.c
> +++ b/drivers/tty/serial/8250/8250_ioc3.c
> @@ -47,7 +47,7 @@ static int serial8250_ioc3_probe(struct platform_device *pdev)
>  	if (!data)
>  		return -ENOMEM;
>  
> -	membase = devm_ioremap_nocache(&pdev->dev, r->start, resource_size(r));
> +	membase = devm_ioremap(&pdev->dev, r->start, resource_size(r));
>  	if (!membase)
>  		return -ENOMEM;

Looks like Linus already fixed this in b0ef7cda8d9b ("Fix up remaining
devm_ioremap_nocache() in SGI IOC3 8250 UART driver")



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 11:39 [PATCH] serial: 8250_ioc3: Fix ioremap call Thomas Bogendoerfer
2020-02-04 14:39 ` Andy Shevchenko
2020-02-10 19:33 ` Greg Kroah-Hartman

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git