From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98BE1C3B186 for ; Mon, 10 Feb 2020 20:50:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D63324673 for ; Mon, 10 Feb 2020 20:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727254AbgBJUuH (ORCPT ); Mon, 10 Feb 2020 15:50:07 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:32969 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727199AbgBJUuH (ORCPT ); Mon, 10 Feb 2020 15:50:07 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1G0K-0006VE-3k; Mon, 10 Feb 2020 21:50:04 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1j1G0J-0001Yq-3k; Mon, 10 Feb 2020 21:50:03 +0100 Date: Mon, 10 Feb 2020 21:50:03 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: George Hilliard Cc: Greg Kroah-Hartman , kernel@pengutronix.de, devicetree@vger.kernel.org, NXP Linux Team , linux-serial@vger.kernel.org Subject: Re: [PATCH v2 2/2] tty: imx serial: Implement support for reversing TX and RX polarity Message-ID: <20200210205003.x7xduj3avwjhimjm@pengutronix.de> References: <20200210192949.7338-1-ghilliard@kopismobile.com> <20200210192949.7338-3-ghilliard@kopismobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200210192949.7338-3-ghilliard@kopismobile.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-serial@vger.kernel.org Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Hello George, On Mon, Feb 10, 2020 at 01:29:49PM -0600, George Hilliard wrote: > @@ -1390,6 +1392,8 @@ static int imx_uart_startup(struct uart_port *port) > ucr4 = imx_uart_readl(sport, UCR4) & ~UCR4_OREN; > if (!sport->dma_is_enabled) > ucr4 |= UCR4_OREN; > + if (sport->inverted_rx) > + ucr4 |= UCR4_INVR; You fail to clear this bit if .inverted_rx is false. > imx_uart_writel(sport, ucr4, UCR4); > > ucr2 = imx_uart_readl(sport, UCR2) & ~UCR2_ATEN; > @@ -1404,19 +1408,17 @@ static int imx_uart_startup(struct uart_port *port) > ucr2 &= ~UCR2_RTSEN; > imx_uart_writel(sport, ucr2, UCR2); > > + ucr3 = imx_uart_readl(sport, UCR3); > + if (sport->inverted_tx) > + ucr3 |= UCR3_INVT; ditto. Also I think setting this bit here is a bit late because UCR2_TXEN was already set so changing UCR3_INVT probably results in a spike?! > if (!imx_uart_is_imx1(sport)) { > - u32 ucr3; > - > - ucr3 = imx_uart_readl(sport, UCR3); > [...] Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |