Linux-Serial Archive on lore.kernel.org
 help / color / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Li,Rongqing" <lirongqing@baidu.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"jslaby@suse.com" <jslaby@suse.com>,
	"haolee.swjtu@gmail.com" <haolee.swjtu@gmail.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: 答复: [PATCH] serial: 8250_pnp: pass IRQ shared flag to UART ports
Date: Tue, 11 Feb 2020 15:47:32 +0200
Message-ID: <20200211134732.GC10400@smile.fi.intel.com> (raw)
In-Reply-To: <09a4fa15c8ae4a7391787e4b4af30399@baidu.com>

On Mon, Feb 10, 2020 at 12:54:47PM +0000, Li,Rongqing wrote:
> > -----邮件原件-----
> > 发件人: Andy Shevchenko [mailto:andriy.shevchenko@linux.intel.com]
> > 发送时间: 2020年2月10日 18:10
> > 收件人: Li,Rongqing <lirongqing@baidu.com>
> > 抄送: gregkh@linuxfoundation.org; jslaby@suse.com;
> > haolee.swjtu@gmail.com; linux-serial@vger.kernel.org
> > 主题: Re: [PATCH] serial: 8250_pnp: pass IRQ shared flag to UART ports
> > On Sun, Feb 09, 2020 at 12:42:27PM +0800, Li RongQing wrote:
> > > On some systems IRQ lines might be shared between multiple devices.
> > > If so, the irqflags have to be configured accordingly. The reason is:
> > > The 8250 port startup code performs IRQ tests *before* the IRQ handler
> > > for that particular port is registered.
> > 
> > Thanks for the report.
> > 
> > Before we proceed with it, can we have more information about the device in
> > question?
> > How is it enumerated? What is in resources (ACPI / or ...?) for this device?
> > Also how IPMI is being involved to all this and why?
> > 
> 
> This is arm server, resource is from dsdt, and detail is

> And I think we has the same issue.
> 
> Author: Kurt Kanzenbach <kurt@linutronix.de>
> Date:   Fri Mar 16 12:31:58 2018 +0100
> 
>     tty: serial: 8250: pass IRQ shared flag to UART ports

Thanks for sharing additional information.

Funny that the mentioned commit describes everything and had done a symptomatic
healing instead of fixing it properly.

So, I will send a patch later Cc'ing you. I would like to be informed if it
helps (in form of Tested-by tag).

-- 
With Best Regards,
Andy Shevchenko



      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09  4:42 Li RongQing
2020-02-10 10:09 ` Andy Shevchenko
2020-02-10 12:54   ` 答复: " Li,Rongqing
2020-02-11 13:47     ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211134732.GC10400@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haolee.swjtu@gmail.com \
    --cc=jslaby@suse.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Serial Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-serial/0 linux-serial/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-serial linux-serial/ https://lore.kernel.org/linux-serial \
		linux-serial@vger.kernel.org
	public-inbox-index linux-serial

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-serial


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git