From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2 4/8] serial: core: Allow detach and attach serial device for console
Date: Mon, 17 Feb 2020 12:23:45 +0200 [thread overview]
Message-ID: <20200217102345.GZ10400@smile.fi.intel.com> (raw)
In-Reply-To: <20200214162847.GB3987177@kroah.com>
On Fri, Feb 14, 2020 at 08:28:47AM -0800, Greg Kroah-Hartman wrote:
> On Fri, Feb 14, 2020 at 01:43:35PM +0200, Andy Shevchenko wrote:
...
> > static DEVICE_ATTR(iomem_base, 0440, uart_get_attr_iomem_base, NULL);
> > static DEVICE_ATTR(iomem_reg_shift, 0440, uart_get_attr_iomem_reg_shift, NULL);
> > +static DEVICE_ATTR(console, 0640, uart_get_attr_console, uart_set_attr_console);
>
> Again, DEVICE_ATTR_RW() in the future?
Fixed for next version, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-02-17 10:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 11:43 [PATCH v2 0/8] serial: Disable DMA and PM on kernel console Andy Shevchenko
2020-02-14 11:43 ` [PATCH v2 1/8] serial: core: Introduce uart_console_enabled() helper Andy Shevchenko
2020-02-14 11:43 ` [PATCH v2 2/8] serial: core: Consolidate spin lock initialization code Andy Shevchenko
2020-02-14 11:43 ` [PATCH v2 3/8] serial: core: use octal permissions on module param Andy Shevchenko
2020-02-14 16:27 ` Greg Kroah-Hartman
2020-02-17 9:15 ` Andy Shevchenko
2020-02-14 11:43 ` [PATCH v2 4/8] serial: core: Allow detach and attach serial device for console Andy Shevchenko
2020-02-14 16:28 ` Greg Kroah-Hartman
2020-02-17 10:23 ` Andy Shevchenko [this message]
2020-02-14 11:43 ` [PATCH v2 5/8] serial: 8250_port: Don't use power management for kernel console Andy Shevchenko
2020-02-14 13:39 ` Russell King - ARM Linux admin
2020-02-14 17:13 ` Tony Lindgren
2020-02-14 18:09 ` Andy Shevchenko
2020-02-14 18:42 ` Tony Lindgren
2020-02-14 19:06 ` Tony Lindgren
2020-02-14 18:14 ` Tony Lindgren
2020-02-14 18:56 ` Andy Shevchenko
2020-02-14 19:02 ` Tony Lindgren
2020-02-14 11:43 ` [PATCH v2 6/8] serial: 8250_port: Disable DMA operations " Andy Shevchenko
2020-02-14 16:30 ` Greg Kroah-Hartman
2020-02-17 9:18 ` Andy Shevchenko
2020-02-14 11:43 ` [PATCH v2 7/8] serial: 8250_mtk: Remove duplicating code to disable DMA Andy Shevchenko
2020-02-14 11:43 ` [PATCH v2 8/8] serial: 8250_omap: " Andy Shevchenko
2020-02-14 16:33 ` [PATCH v2 0/8] serial: Disable DMA and PM on kernel console Greg Kroah-Hartman
2020-02-14 21:41 ` Tony Lindgren
2020-02-17 10:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200217102345.GZ10400@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-serial@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).