On Wed 2020-02-19 11:40:12, Greg Kroah-Hartman wrote: > On Thu, Feb 13, 2020 at 10:15:56AM +0100, Uwe Kleine-König wrote: > > From: Uwe Kleine-König > > > > Hello, > > > > This is v6 of my quest to introduce ledtriggers for UARTs. The previous > > series is available at > > > > http://lore.kernel.org/r/20191219093947.15502-1-u.kleine-koenig@pengutronix.de > > > > The changes compared to that are that parsing of the dev parameter is > > more strict and that I set brightness directly from the kworker instead > > of using led_blink_set_oneshot which makes use of another kworker. (Both > > requested by Pavel Machek.) > > > > For the former I introduced a new helper kstrtodev_t() in the spirit of > > kstrtoul() to implement the stricter parsing (instead of the lax one > > using plain sscanf() in v5). > > Looks good to me, Pavel, any objection to me merging this through the > tty tree? I see ton of comments on this one, seems like there will be one more version? And I fear merge conflicts if you modify drivers/leds/Makefile... Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html