linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tty: serial: atmel_serial: Drop GPIO includes
@ 2020-02-29 22:09 Linus Walleij
  2020-03-03  7:41 ` Ludovic Desroches
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2020-02-29 22:09 UTC (permalink / raw)
  To: linux-serial, Greg Kroah-Hartman
  Cc: Linus Walleij, Ludovic Desroches, Razvan Stefanescu

Nothing in this driver uses the symbols from these GPIO
includes so drop them. These are probably just historical
artifacts from befor mctrl_gpio was used.

Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Razvan Stefanescu <razvan.stefanescu@microchip.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/tty/serial/atmel_serial.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index c15c398c88a9..801b998c87e7 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -20,15 +20,12 @@
 #include <linux/platform_device.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
-#include <linux/of_gpio.h>
 #include <linux/dma-mapping.h>
 #include <linux/dmaengine.h>
 #include <linux/atmel_pdc.h>
 #include <linux/uaccess.h>
 #include <linux/platform_data/atmel.h>
 #include <linux/timer.h>
-#include <linux/gpio.h>
-#include <linux/gpio/consumer.h>
 #include <linux/err.h>
 #include <linux/irq.h>
 #include <linux/suspend.h>
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tty: serial: atmel_serial: Drop GPIO includes
  2020-02-29 22:09 [PATCH] tty: serial: atmel_serial: Drop GPIO includes Linus Walleij
@ 2020-03-03  7:41 ` Ludovic Desroches
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Desroches @ 2020-03-03  7:41 UTC (permalink / raw)
  To: Linus Walleij; +Cc: linux-serial, Greg Kroah-Hartman, Razvan Stefanescu

On Sat, Feb 29, 2020 at 11:09:41PM +0100, Linus Walleij wrote:
> 
> Nothing in this driver uses the symbols from these GPIO
> includes so drop them. These are probably just historical
> artifacts from befor mctrl_gpio was used.
> 
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Razvan Stefanescu <razvan.stefanescu@microchip.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Ludovic Desroches <ludovic.desroches@microchip.com>

Thanks.

> ---
>  drivers/tty/serial/atmel_serial.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index c15c398c88a9..801b998c87e7 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -20,15 +20,12 @@
>  #include <linux/platform_device.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
> -#include <linux/of_gpio.h>
>  #include <linux/dma-mapping.h>
>  #include <linux/dmaengine.h>
>  #include <linux/atmel_pdc.h>
>  #include <linux/uaccess.h>
>  #include <linux/platform_data/atmel.h>
>  #include <linux/timer.h>
> -#include <linux/gpio.h>
> -#include <linux/gpio/consumer.h>
>  #include <linux/err.h>
>  #include <linux/irq.h>
>  #include <linux/suspend.h>
> --
> 2.24.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-03  7:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-29 22:09 [PATCH] tty: serial: atmel_serial: Drop GPIO includes Linus Walleij
2020-03-03  7:41 ` Ludovic Desroches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).