linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [tty:tty-testing 76/89] drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
@ 2020-03-06 13:57 kbuild test robot
  2020-03-07  8:52 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-03-06 13:57 UTC (permalink / raw)
  To: Vincent Chen; +Cc: kbuild-all, linux-serial, Greg Kroah-Hartman

[-- Attachment #1: Type: text/plain, Size: 2469 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
head:   8434c477300896e50907650a7476116249030b16
commit: cc2d0148b11763808c835ec5a413620ad92fc340 [76/89] tty: serial: Add CONSOLE_POLL support to SiFive UART
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout cc2d0148b11763808c835ec5a413620ad92fc340
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
     .poll_get_char = sifive_serial_poll_get_char,
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                      sifive_serial_clk_notifier
>> drivers/tty/serial/sifive.c:905:19: error: 'sifive_serial_poll_put_char' undeclared here (not in a function); did you mean 'sifive_serial_poll_get_char'?
     .poll_put_char = sifive_serial_poll_put_char,
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                      sifive_serial_poll_get_char

vim +904 drivers/tty/serial/sifive.c

   886	
   887	static const struct uart_ops sifive_serial_uops = {
   888		.tx_empty	= sifive_serial_tx_empty,
   889		.set_mctrl	= sifive_serial_set_mctrl,
   890		.get_mctrl	= sifive_serial_get_mctrl,
   891		.stop_tx	= sifive_serial_stop_tx,
   892		.start_tx	= sifive_serial_start_tx,
   893		.stop_rx	= sifive_serial_stop_rx,
   894		.break_ctl	= sifive_serial_break_ctl,
   895		.startup	= sifive_serial_startup,
   896		.shutdown	= sifive_serial_shutdown,
   897		.set_termios	= sifive_serial_set_termios,
   898		.type		= sifive_serial_type,
   899		.release_port	= sifive_serial_release_port,
   900		.request_port	= sifive_serial_request_port,
   901		.config_port	= sifive_serial_config_port,
   902		.verify_port	= sifive_serial_verify_port,
   903	#ifdef CONFIG_CONSOLE_POLL
 > 904		.poll_get_char	= sifive_serial_poll_get_char,
 > 905		.poll_put_char	= sifive_serial_poll_put_char,
   906	#endif
   907	};
   908	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53767 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [tty:tty-testing 76/89] drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
  2020-03-06 13:57 [tty:tty-testing 76/89] drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'? kbuild test robot
@ 2020-03-07  8:52 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2020-03-07  8:52 UTC (permalink / raw)
  To: kbuild test robot; +Cc: Vincent Chen, kbuild-all, linux-serial

On Fri, Mar 06, 2020 at 09:57:25PM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> head:   8434c477300896e50907650a7476116249030b16
> commit: cc2d0148b11763808c835ec5a413620ad92fc340 [76/89] tty: serial: Add CONSOLE_POLL support to SiFive UART
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout cc2d0148b11763808c835ec5a413620ad92fc340
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=sh 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'?
>      .poll_get_char = sifive_serial_poll_get_char,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>                       sifive_serial_clk_notifier
> >> drivers/tty/serial/sifive.c:905:19: error: 'sifive_serial_poll_put_char' undeclared here (not in a function); did you mean 'sifive_serial_poll_get_char'?
>      .poll_put_char = sifive_serial_poll_put_char,
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>                       sifive_serial_poll_get_char
> 
> vim +904 drivers/tty/serial/sifive.c
> 
>    886	
>    887	static const struct uart_ops sifive_serial_uops = {
>    888		.tx_empty	= sifive_serial_tx_empty,
>    889		.set_mctrl	= sifive_serial_set_mctrl,
>    890		.get_mctrl	= sifive_serial_get_mctrl,
>    891		.stop_tx	= sifive_serial_stop_tx,
>    892		.start_tx	= sifive_serial_start_tx,
>    893		.stop_rx	= sifive_serial_stop_rx,
>    894		.break_ctl	= sifive_serial_break_ctl,
>    895		.startup	= sifive_serial_startup,
>    896		.shutdown	= sifive_serial_shutdown,
>    897		.set_termios	= sifive_serial_set_termios,
>    898		.type		= sifive_serial_type,
>    899		.release_port	= sifive_serial_release_port,
>    900		.request_port	= sifive_serial_request_port,
>    901		.config_port	= sifive_serial_config_port,
>    902		.verify_port	= sifive_serial_verify_port,
>    903	#ifdef CONFIG_CONSOLE_POLL
>  > 904		.poll_get_char	= sifive_serial_poll_get_char,
>  > 905		.poll_put_char	= sifive_serial_poll_put_char,
>    906	#endif
>    907	};
>    908	

I'm dropping this patch from my tree now.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-07  8:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 13:57 [tty:tty-testing 76/89] drivers/tty/serial/sifive.c:904:19: error: 'sifive_serial_poll_get_char' undeclared here (not in a function); did you mean 'sifive_serial_clk_notifier'? kbuild test robot
2020-03-07  8:52 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).