From: Heiko Stuebner <heiko@sntech.de>
To: gregkh@linuxfoundation.org
Cc: jslaby@suse.com, andriy.shevchenko@linux.intel.com,
matwey.kornilov@gmail.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, heiko@sntech.de,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: [PATCH 5/7] serial: 8250: handle DTR in rs485 emulation
Date: Wed, 18 Mar 2020 15:26:38 +0100 [thread overview]
Message-ID: <20200318142640.982763-6-heiko@sntech.de> (raw)
In-Reply-To: <20200318142640.982763-1-heiko@sntech.de>
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
While in a lot of cases only RTS is needed as DE signal, sometimes the
RE signals is to be controlled separately, as DTR pin.
So add necessary control functions for it.
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
---
drivers/tty/serial/8250/8250_port.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c
index 3d1d8490bc42..f8e5c096ed51 100644
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -572,6 +572,10 @@ static inline void serial8250_em485_rts_after_send(struct uart_8250_port *p)
mcr &= ~UART_MCR_RTS;
p->port.mctrl &= ~TIOCM_RTS;
}
+
+ mcr |= UART_MCR_DTR;
+ p->port.mctrl |= TIOCM_DTR;
+
serial8250_out_MCR(p, mcr);
}
@@ -1558,6 +1562,13 @@ static inline void start_tx_rs485(struct uart_port *port)
em485->active_timer = NULL;
mcr = serial8250_in_MCR(up);
+
+ /* in rx_during_tx mode keep DTR active, to receive data */
+ if (up->port.rs485.flags & SER_RS485_RX_DURING_TX)
+ mcr |= UART_MCR_DTR;
+ else
+ mcr &= ~UART_MCR_DTR;
+
if (!!(up->port.rs485.flags & SER_RS485_RTS_ON_SEND) !=
!!(mcr & UART_MCR_RTS)) {
if (up->port.rs485.flags & SER_RS485_RTS_ON_SEND)
@@ -1572,6 +1583,8 @@ static inline void start_tx_rs485(struct uart_port *port)
up->port.rs485.delay_rts_before_send);
return;
}
+ } else {
+ serial8250_out_MCR(up, mcr);
}
__start_tx(port);
--
2.24.1
next prev parent reply other threads:[~2020-03-18 14:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 14:26 [PATCH 0/7] serial: 8250: Add rs485 emulation to 8250_dw Heiko Stuebner
2020-03-18 14:26 ` [PATCH 1/7] serial: 8250: Make em485_rts_after_send() set mctrl according to rts state Heiko Stuebner
2020-03-18 14:26 ` [PATCH 2/7] serial: 8250: add serial_in_poll_timeout helper Heiko Stuebner
2020-03-18 15:09 ` Andy Shevchenko
2020-03-18 14:26 ` [PATCH 3/7] serial: 8250: Handle case port doesn't have TEMT interrupt using em485 Heiko Stuebner
2020-03-18 14:26 ` [PATCH 4/7] serial: 8250: Start rs485 after registering port if rs485 is enabled in probe Heiko Stuebner
2020-03-18 14:26 ` Heiko Stuebner [this message]
2020-03-18 14:26 ` [PATCH 6/7] serial: 8250_dw: add em485 support Heiko Stuebner
2020-03-18 15:15 ` Andy Shevchenko
2020-03-18 14:26 ` [PATCH 7/7] serial: 8250_dw: allow enable rs485 at boot time Heiko Stuebner
2020-03-18 15:16 ` Andy Shevchenko
2020-03-18 18:28 ` Heiko Stübner
2020-03-18 18:31 ` Heiko Stübner
2020-03-18 14:43 ` [PATCH 0/7] serial: 8250: Add rs485 emulation to 8250_dw Andy Shevchenko
2020-03-18 15:37 ` Lukas Wunner
2020-03-18 15:54 ` Andy Shevchenko
2020-03-18 18:49 ` Heiko Stübner
2020-03-19 5:40 ` Lukas Wunner
2020-03-23 8:25 ` Heiko Stübner
2020-03-23 13:17 ` Lukas Wunner
2020-03-23 13:41 ` Andy Shevchenko
2020-03-25 13:41 ` Heiko Stübner
2020-03-25 14:42 ` Andy Shevchenko
2020-03-18 15:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318142640.982763-6-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matwey.kornilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).