linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Anatoly Pugachev <matorola@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-serial@vger.kernel.org,
	Sparc kernel list <sparclinux@vger.kernel.org>,
	David Miller <davem@davemloft.net>
Subject: Re: [PATCH v1] serial: sunhv: Initialize lock for non-registered console
Date: Mon, 6 Apr 2020 13:52:27 +0300	[thread overview]
Message-ID: <20200406105227.GP3676135@smile.fi.intel.com> (raw)
In-Reply-To: <CADxRZqzgenruphXAKE8MJM2zayR7u7yvc=-5YwPHkCN4gW2eNQ@mail.gmail.com>

On Sat, Apr 04, 2020 at 08:50:56PM +0300, Anatoly Pugachev wrote:
> On Thu, Apr 2, 2020 at 8:20 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > The commit a3cb39d258ef
> > ("serial: core: Allow detach and attach serial device for console")
> > changed a bit logic behind lock initialization since for most of the console
> > driver it's supposed to have lock already initialized even if console is not
> > enabled. However, it's not the case for Sparc HV console.
> >
> > Initialize lock explicitly in the ->probe().
> >
> > Note, there is still an open question should or shouldn't not this driver
> > register console properly.
> >
> > Fixes: a3cb39d258ef ("serial: core: Allow detach and attach serial device for console")
> > Reported-by: Anatoly Pugachev <matorola@gmail.com>
> > Cc: David Miller <davem@davemloft.net>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/tty/serial/sunhv.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> 
> fixes issue for me, sorry for the late testing

Thank you! Can you formally provide a Tested-by tag?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2020-04-06 10:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-02 17:20 [PATCH v1] serial: sunhv: Initialize lock for non-registered console Andy Shevchenko
2020-04-02 17:38 ` Greg Kroah-Hartman
2020-04-04 17:50 ` Anatoly Pugachev
2020-04-06 10:52   ` Andy Shevchenko [this message]
2020-04-06 10:57     ` Anatoly Pugachev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406105227.GP3676135@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=matorola@gmail.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).