From: Arseny Maslennikov <ar@cs.msu.ru>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Landley <rob@landley.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Pavel Machek <pavel@ucw.cz>,
linux-api@vger.kernel.org,
"Vladimir D. Seleznev" <vseleznv@altlinux.org>
Subject: Re: [PATCH v3 5/7] tty: Add NOKERNINFO lflag to termios
Date: Thu, 30 Apr 2020 10:20:22 +0300 [thread overview]
Message-ID: <20200430072022.GI43805@cello> (raw)
In-Reply-To: <323be592-b614-907d-e9be-4748f159fb07@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On Thu, Apr 30, 2020 at 08:55:43AM +0200, Jiri Slaby wrote:
> On 30. 04. 20, 8:42, Arseny Maslennikov wrote:
> > The termios lflag is off by default.
>
> This commit message is too poor. Describing the intended use would help.
>
I described its use in the last patch of the series, where it actually
gains some use.
I agree, however, that the limited explanation in this commit does not
look helpful at all when looking at e.g. git blame output.
I'll resend a v4 with this commit message improved.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-04-30 7:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 6:42 [PATCH v3 0/7] TTY Keyboard Status Request Arseny Maslennikov
2020-04-30 6:42 ` [PATCH v3 1/7] signal.h: Define SIGINFO on all architectures Arseny Maslennikov
2020-04-30 6:42 ` [PATCH v3 2/7] tty: termios: Reserve space for VSTATUS in .c_cc Arseny Maslennikov
2020-04-30 6:42 ` [PATCH v3 3/7] n_tty: Send SIGINFO to fg pgrp on status request character Arseny Maslennikov
2020-04-30 6:42 ` [PATCH v3 4/7] linux/signal.h: Ignore SIGINFO by default in new tasks Arseny Maslennikov
2020-04-30 6:53 ` Jiri Slaby
2020-04-30 7:14 ` Christian Brauner
2020-04-30 7:19 ` Greg Kroah-Hartman
2020-04-30 7:37 ` Aleksa Sarai
2020-04-30 8:00 ` Christian Brauner
2020-04-30 6:42 ` [PATCH v3 5/7] tty: Add NOKERNINFO lflag to termios Arseny Maslennikov
2020-04-30 6:55 ` Jiri Slaby
2020-04-30 7:20 ` Arseny Maslennikov [this message]
2020-04-30 6:43 ` [PATCH v3 6/7] n_tty: ->ops->write: Cut core logic out to a separate function Arseny Maslennikov
2020-04-30 6:43 ` [PATCH v3 7/7] n_tty: Provide an informational line on VSTATUS receipt Arseny Maslennikov
2020-04-30 7:29 ` Jiri Slaby
2020-04-30 9:08 ` Arseny Maslennikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430072022.GI43805@cello \
--to=ar@cs.msu.ru \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rob@landley.net \
--cc=vseleznv@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).