From: Alper Nebi Yasak <alpernebiyasak@gmail.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Petr Mladek <pmladek@suse.com>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> Cc: linux-serial@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>, Alper Nebi Yasak <alpernebiyasak@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 3/3] printk: Preset tty0 as a pseudo-preferred console Date: Thu, 30 Apr 2020 19:14:37 +0300 [thread overview] Message-ID: <20200430161438.17640-4-alpernebiyasak@gmail.com> (raw) In-Reply-To: <20200430161438.17640-1-alpernebiyasak@gmail.com> The ACPI SPCR (Serial Port Console Redirection) table from a machine's firmware can specify a serial console which can be used for earlycon. However, in at least ARM64 systems the same device is also set up as the preferred console. Presumably due to the order of acpi_parse_spcr and VT's register_device calls, setting the specified console as the preferred one can prevent registering VT as a console. This might look appropriate for machines which do not have or need working graphics and whose users most likely have access to a serial port. However, the use of SPCR tables may not be limited these. For example, ARM64 QEMU virtual machines include a SPCR table regardless of the existence of a graphics output or even the nonexistence of a serial console. Or server hardware which has a SPCR table can be repurposed into a workstation with the addition of a graphics card. As a result, boot messages and early userspace prompts can go to an unexpected console. This patch presets tty0 as a pseudo-preferred console at compile-time to ensure that CONFIG_VT_CONSOLE always results in the VT console getting registered. With this, VT can get registered, these other consoles are preferred when VT is a dummy, but we can also bump up VTs preference when working graphics are available. Without this patch, an ARM64 QEMU virtual machine has roughly the following order of console events and consoles: # Without earlycon: $ sudo dmesg | grep -i "console\|printk\|tty[0-9a-z]" | grep -v systemd [ 0.000000] ACPI: SPCR: console: pl011,mmio,0x9000000,9600 [ 0.000250] Console: colour dummy device 80x25 [ 0.140955] ARMH0011:00: ttyAMA0 at MMIO 0x9000000 (irq = 4, base_baud = 0) is a SBSA [ 0.317189] printk: console [ttyAMA0] enabled [ 3.540272] Console: switching to colour frame buffer device 150x42 $ cat /proc/consoles ttyAMA0 -W- (EC p a) 204:64 # With earlycon: $ sudo dmesg | grep -i "console\|printk\|tty[0-9a-z]" | grep -v systemd [ 0.000000] ACPI: SPCR: console: pl011,mmio,0x9000000,9600 [ 0.000000] printk: bootconsole [pl11] enabled [ 0.002064] Console: colour dummy device 80x25 [ 0.324415] ARMH0011:00: ttyAMA0 at MMIO 0x9000000 (irq = 4, base_baud = 0) is a SBSA [ 0.327047] printk: console [ttyAMA0] enabled [ 0.329139] printk: bootconsole [pl11] disabled [ 3.704937] Console: switching to colour frame buffer device 150x42 $ cat /proc/consoles ttyAMA0 -W- (EC a) 204:64 In addition, boot messages aren't printed to the framebuffer (as tty0 is not registered). With this patch, boot messages are visible on the framebuffer and the information above becomes: # Without earlycon: $ sudo dmesg | grep -i "console\|printk\|tty[0-9a-z]" | grep -v systemd [ 0.000000] ACPI: SPCR: console: pl011,mmio,0x9000000,9600 [ 0.000058] Console: colour dummy device 80x25 [ 0.000266] printk: console [tty0] enabled [ 0.144615] ARMH0011:00: ttyAMA0 at MMIO 0x9000000 (irq = 4, base_baud = 0) is a SBSA [ 0.299031] printk: console [ttyAMA0] enabled [ 3.320333] Console: switching to colour frame buffer device 150x42 [ 3.329386] printk: switching to console [tty0] $ cat /proc/consoles tty0 -WU (EC p ) 4:7 ttyAMA0 -W- (E p a) 204:64 # With earlycon: $ sudo dmesg | grep -i "console\|printk\|tty[0-9a-z]" | grep -v systemd [ 0.000000] ACPI: SPCR: console: pl011,mmio,0x9000000,9600 [ 0.000000] printk: bootconsole [pl11] enabled [ 0.002326] Console: colour dummy device 80x25 [ 0.003545] printk: console [tty0] enabled [ 0.236824] ARMH0011:00: ttyAMA0 at MMIO 0x9000000 (irq = 4, base_baud = 0) is a SBSA [ 0.239243] printk: console [ttyAMA0] enabled [ 0.241324] printk: bootconsole [pl11] disabled [ 3.715086] Console: switching to colour frame buffer device 150x42 [ 3.742923] printk: switching to console [tty0] $ cat /proc/consoles tty0 -WU (EC p ) 4:7 ttyAMA0 -W- (E a) 204:64 Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com> --- Changes in v2: - Fix #elif to #else (Reported-by: kbuild test robot <lkp@intel.com>) - Refresh dmesg outputs with/without earlycon for next-20200430 kernel/printk/printk.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index efda422203e4..aa9f9f16860f 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -277,7 +277,19 @@ static struct console *exclusive_console; #define MAX_CMDLINECONSOLES 8 +/* + * The preferred_console and has_preferred_console variables are + * intentionally not modified to reflect this so that the first + * registered console is still used as the preferred console. + */ +#ifdef CONFIG_VT_CONSOLE +static struct console_cmdline console_cmdline[MAX_CMDLINECONSOLES] = { + [0].name = "tty", + [0].index = 0, +}; +#else static struct console_cmdline console_cmdline[MAX_CMDLINECONSOLES]; +#endif static int preferred_console = -1; static bool has_preferred_console; -- 2.26.2
next prev parent reply other threads:[~2020-04-30 16:16 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-30 16:14 [RFC PATCH v2 0/3] Prefer working VT console over SPCR and device-tree chosen stdout-path Alper Nebi Yasak 2020-04-30 16:14 ` [RFC PATCH v2 1/3] printk: Add function to set console to preferred console's driver Alper Nebi Yasak 2020-04-30 16:46 ` Andy Shevchenko 2020-05-01 1:44 ` Sergey Senozhatsky 2020-05-01 11:48 ` Alper Nebi Yasak 2020-05-13 5:35 ` Sergey Senozhatsky 2020-05-24 10:01 ` Daniel Vetter 2020-04-30 16:14 ` [RFC PATCH v2 2/3] vt: Set as preferred console when a non-dummy backend is bound Alper Nebi Yasak 2020-04-30 16:14 ` Alper Nebi Yasak [this message] 2020-04-30 16:44 ` [RFC PATCH v2 0/3] Prefer working VT console over SPCR and device-tree chosen stdout-path Andy Shevchenko 2020-04-30 19:32 ` Alper Nebi Yasak 2020-05-01 1:30 ` Sergey Senozhatsky 2020-05-01 11:08 ` Alper Nebi Yasak 2020-05-01 13:16 ` Andy Shevchenko 2020-05-01 15:07 ` Alper Nebi Yasak 2020-05-13 14:37 ` Petr Mladek 2020-05-13 22:22 ` Benjamin Herrenschmidt 2020-05-15 19:27 ` Alper Nebi Yasak 2020-05-25 13:04 ` Petr Mladek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200430161438.17640-4-alpernebiyasak@gmail.com \ --to=alpernebiyasak@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jslaby@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=sergey.senozhatsky@gmail.com \ --subject='Re: [RFC PATCH v2 3/3] printk: Preset tty0 as a pseudo-preferred console' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).