From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95C07C47256 for ; Fri, 1 May 2020 14:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7666D20757 for ; Fri, 1 May 2020 14:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729486AbgEAOUZ (ORCPT ); Fri, 1 May 2020 10:20:25 -0400 Received: from muru.com ([72.249.23.125]:52482 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728839AbgEAOUZ (ORCPT ); Fri, 1 May 2020 10:20:25 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3BFC4810E; Fri, 1 May 2020 14:21:10 +0000 (UTC) Date: Fri, 1 May 2020 07:20:18 -0700 From: Tony Lindgren To: Pavel Machek Cc: Greg Kroah-Hartman , Johan Hovold , Rob Herring , Alan Cox , Lee Jones , Jiri Slaby , Merlijn Wajer , Peter Hurley , Sebastian Reichel , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCHv6 0/6] n_gsm serdev support and GNSS driver for droid4 Message-ID: <20200501142018.GB37466@atomide.com> References: <20200430174615.41185-1-tony@atomide.com> <20200501082111.GA7501@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200501082111.GA7501@amd> Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org * Pavel Machek [200501 08:22]: > Hi! > > > Now without the chardev support, the /dev/gsmtty* using apps need > > to use "U1234AT+CFUN?" format for the packets. The advantage is > > less kernel code, and we keep the existing /dev/gsmtty* interface. > > Actually... yes, this works. But no, this is not "existing" tty > interface. > > ttys work per character, and this interface definitely does not... it > is "packet" based, write() syscalls need exactly right lengths. You > can't just open minicom, and type "U1234...". You can't paste it, > either (I tried). tty controls like start/stop bits and baud rate are > useless here. CR/LF conversions are unwanted/dangerous because it is > confusing hard to debug if you get them wrong. Yes.. That's what n_gsm spins up. > Now, I don't see reason why this could not be made to work, and it may > be more important to have something in mainline and work with that. So > if you can make this into -next, I'll not complain too loudly. But it > is... still wrong and I liked motmdm* more :-). Yes.. There are issues too with the motmdm* char dev interface too. I don't think it would work as is for devices with network interfaces on some channel, and continuation packets could need more handling possibly. But let's try to get the basics sorted out first and use the "raw" gsmtty* interface. More stuff can always be added later as needed. Regards, Tony