linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Rahul Tanwar <rahul.tanwar@linux.intel.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	andriy.shevchenko@intel.com
Subject: Re: [PATCH] serial: lantiq: Make driver modular and console configurable
Date: Fri, 8 May 2020 13:32:33 +0200	[thread overview]
Message-ID: <20200508113233.GA4043190@kroah.com> (raw)
In-Reply-To: <42292519ba78f086eb19d058dec6411f5f29da51.1588936756.git.rahul.tanwar@linux.intel.com>

On Fri, May 08, 2020 at 07:20:49PM +0800, Rahul Tanwar wrote:
> Add changes so Lantiq serial driver can be compiled as a module.
> Also, make this driver's use as console selectable/configurable.

When you say "also" in a patch description, that's usually a huge hint
that this needs to be broken up into multiple patches.

Please do that here, this should be 2.

thanks,

greg k-h

      reply	other threads:[~2020-05-08 11:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 11:20 [PATCH] serial: lantiq: Make driver modular and console configurable Rahul Tanwar
2020-05-08 11:32 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200508113233.GA4043190@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rahul.tanwar@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).