From: Lukas Wunner <lukas@wunner.de>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
andriy.shevchenko@linux.intel.com, matwey.kornilov@gmail.com,
giulio.benetti@micronovasrl.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO
Date: Mon, 18 May 2020 11:19:03 +0200 [thread overview]
Message-ID: <20200518091903.4rj5exdfrb53vfzz@wunner.de> (raw)
In-Reply-To: <2693913.H5ugjTTm6y@diego>
On Mon, May 18, 2020 at 10:04:05AM +0200, Heiko Stübner wrote:
> Am Montag, 18. Mai 2020, 06:50:06 CEST schrieb Lukas Wunner:
> > On Sun, May 17, 2020 at 11:56:08PM +0200, Heiko Stuebner wrote:
> > > @@ -1457,6 +1458,7 @@ void serial8250_em485_stop_tx(struct uart_8250_port *p)
> > > * Enable previously disabled RX interrupts.
> > > */
> > > if (!(p->port.rs485.flags & SER_RS485_RX_DURING_TX)) {
> > > + gpiod_set_value(port->rs485_re_gpio, 1);
> > > serial8250_clear_and_reinit_fifos(p);
> > >
> > > p->ier |= UART_IER_RLSI | UART_IER_RDI;
> >
> > The added line needs to be conditional on if (port->rs485_re_gpio)
> > because the gpiod could be NULL and gpiod_set_value() doesn't check
> > for that.
>
> Need to look deeper at the other comment below, but gpiod_set_value does
> check for NULL ;-)
I'll be damned. That means I should respin my patch [4/4] and
drop the NULL check. :-/
Thanks!
Lukas
next prev parent reply other threads:[~2020-05-18 9:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-17 21:56 [PATCH v3 0/5] serial: 8250: Add rs485 emulation to 8250_dw Heiko Stuebner
2020-05-17 21:56 ` [PATCH v3 1/5] serial: 8520_port: Fix function param documentation Heiko Stuebner
2020-05-18 15:09 ` Andy Shevchenko
2020-05-17 21:56 ` [PATCH v3 2/5] dt-bindings: serial: Add binding for rs485 receiver enable GPIO Heiko Stuebner
2020-05-17 21:56 ` [PATCH v3 3/5] serial: 8250: Support separate rs485 rx-enable GPIO Heiko Stuebner
2020-05-18 4:50 ` Lukas Wunner
2020-05-18 8:04 ` Heiko Stübner
2020-05-18 9:19 ` Lukas Wunner [this message]
2020-05-18 15:12 ` Andy Shevchenko
2020-05-18 15:22 ` Lukas Wunner
2020-05-18 15:24 ` Lukas Wunner
2020-05-18 16:13 ` Maarten Brock
2020-05-18 16:35 ` Andy Shevchenko
2020-05-18 17:05 ` Maarten Brock
2020-05-18 17:16 ` Andy Shevchenko
2024-01-24 10:29 ` Farouk Bouabid
2020-05-17 21:56 ` [PATCH v3 4/5] serial: 8250: Handle implementations not having TEMT interrupt using em485 Heiko Stuebner
2020-05-18 15:19 ` Andy Shevchenko
2020-05-17 21:56 ` [PATCH v3 5/5] serial: 8250_dw: add em485 support Heiko Stuebner
2020-05-18 15:21 ` Andy Shevchenko
2021-02-02 0:31 ` Giulio Benetti
2021-02-02 11:22 ` Andy Shevchenko
2021-02-05 17:46 ` Giulio Benetti
2021-02-05 19:29 ` Andy Shevchenko
2022-09-22 9:56 ` [PATCH v3 0/5] serial: 8250: Add rs485 emulation to 8250_dw Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518091903.4rj5exdfrb53vfzz@wunner.de \
--to=lukas@wunner.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=giulio.benetti@micronovasrl.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=matwey.kornilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).