[PATCH] serial: 8250: Enable 16550A variants by default on non-x86

[PATCH] serial: 8250: Enable 16550A variants by default on non-x86

[Josh Triplett]

Some embedded devices still use these serial ports; make sure they're
still enabled by default on architectures more likely to have them, to
avoid rendering someone's console unavailable.

Fixes: dc56ecb81a0a ("serial: 8250: Support disabling mdelay-filled probes of 16550A variants")
Signed-off-by: Josh Triplett <josh@joshtriplett.org>
---

Based on user reports from embedded devices that need these variants.

 drivers/tty/serial/8250/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index af0688156dd0..8195a31519ea 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -63,6 +63,7 @@ config SERIAL_8250_PNP
 config SERIAL_8250_16550A_VARIANTS
 	bool "Support for variants of the 16550A serial port"
 	depends on SERIAL_8250
+	default !X86
 	help
 	  The 8250 driver can probe for many variants of the venerable 16550A
 	  serial port. Doing so takes additional time at boot.
-- 
2.27.0.rc0

Re: [PATCH] serial: 8250: Enable 16550A variants by default on non-x86

[Greg Kroah-Hartman]

On Tue, May 26, 2020 at 01:40:06AM -0700, Josh Triplett wrote:
> Some embedded devices still use these serial ports; make sure they're
> still enabled by default on architectures more likely to have them, to
> avoid rendering someone's console unavailable.
> 
> Fixes: dc56ecb81a0a ("serial: 8250: Support disabling mdelay-filled probes of 16550A variants")
> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> ---
> 
> Based on user reports from embedded devices that need these variants.

No "reported-by:" lines for these people?  Not even the author of the
other competing patch for this issue?

Please fix up and resend.

thanks,

greg k-h

Re: [PATCH] serial: 8250: Enable 16550A variants by default on non-x86

[Josh Triplett]

On Tue, May 26, 2020 at 11:47:44AM +0200, Greg Kroah-Hartman wrote:
> On Tue, May 26, 2020 at 01:40:06AM -0700, Josh Triplett wrote:
> > Some embedded devices still use these serial ports; make sure they're
> > still enabled by default on architectures more likely to have them, to
> > avoid rendering someone's console unavailable.
> > 
> > Fixes: dc56ecb81a0a ("serial: 8250: Support disabling mdelay-filled probes of 16550A variants")
> > Signed-off-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> > 
> > Based on user reports from embedded devices that need these variants.
> 
> No "reported-by:" lines for these people?  Not even the author of the
> other competing patch for this issue?

Genuinely forgot that the "Reported-by" tag existed; thank you for the
reminder. Will fix.

- Josh Triplett