From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6ACFC433DF for ; Thu, 25 Jun 2020 10:53:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B00C9207BB for ; Thu, 25 Jun 2020 10:53:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593082383; bh=xQYMEBX8Mbh29sjJ9o2nePFuoAeEimDK6OFXSbmCjTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=f4MD8qlQtwYQs8G1LXSLsLDkDpMDPyzSAki6A3iX9OUuLL5mNkHRO70KC5j/dAU3o 9tVRs5wSRBvICtWyEM/LdqvuGFnPWdQpawfP1XZWLsZJGVtRMyCsSjbVf3GoLcYtxX IEuEGfM7hzG9hQNblCez8AO2Igd9s/7WdvOVluyA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404057AbgFYKxD (ORCPT ); Thu, 25 Jun 2020 06:53:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:48254 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403952AbgFYKxC (ORCPT ); Thu, 25 Jun 2020 06:53:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7EFB52076E; Thu, 25 Jun 2020 10:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593082381; bh=xQYMEBX8Mbh29sjJ9o2nePFuoAeEimDK6OFXSbmCjTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X9P4QH0+uB4dIHxeqlov7R3GtEi1KhQo9JtH6jWsxDDjYzI+uTldWZERude6/N8bM 0d5cGKl72i48gvEtSAmV5fLTQkwnLmhJnzw6wM8Q6yu2+dWy9SaFW743JfUk5Nl0k3 a1Gx3nvqYS/SWhZHTS722OmBwzHy+QcA3KlBaxuY= Date: Thu, 25 Jun 2020 12:52:56 +0200 From: Greg KH To: "Vabhav Sharma (OSS)" Cc: "jslaby@suse.com" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Varun Sethi Subject: Re: [PATCH] tty: serial: fsl_lpuart: minimum baud rate support Message-ID: <20200625105256.GA3335222@kroah.com> References: <1593078545-11272-1-git-send-email-vabhav.sharma@oss.nxp.com> <20200625100410.GA3327034@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Jun 25, 2020 at 10:12:54AM +0000, Vabhav Sharma (OSS) wrote: > > > > -----Original Message----- > > From: Greg KH > > Sent: Thursday, June 25, 2020 3:34 PM > > To: Vabhav Sharma (OSS) > > Cc: jslaby@suse.com; linux-serial@vger.kernel.org; linux- > > kernel@vger.kernel.org; Varun Sethi ; Vabhav Sharma > > > > Subject: Re: [PATCH] tty: serial: fsl_lpuart: minimum baud rate support > > > > On Thu, Jun 25, 2020 at 03:19:05PM +0530, Vabhav Sharma wrote: > > > From: Vabhav Sharma > > > > > > The formula for the baud rate is > > > baud rate = "baud clock / ((OSR+1) × SBR) > > > > > > Algorithm used in function lpuart32_serial_setbrg() only changes the > > > SBR. Even with maxmum value put in, OSR stays at 0x7 and the lowest > > > baud rate would be ~ 2600 bps > > > > > > Update the algorithm to allow driver operation at 1200,2400 or > > > 600 bps > > > > > > Signed-off-by: Vabhav Sharma > > > --- > > > drivers/tty/serial/fsl_lpuart.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/tty/serial/fsl_lpuart.c > > > b/drivers/tty/serial/fsl_lpuart.c index 90298c4..0fd0fa5f 100644 > > > --- a/drivers/tty/serial/fsl_lpuart.c > > > +++ b/drivers/tty/serial/fsl_lpuart.c > > > @@ -1925,6 +1925,10 @@ static void __lpuart32_serial_setbrg(struct > > uart_port *port, > > > tmp_sbr++; > > > } > > > > > > + if (tmp_sbr > UARTBAUD_SBR_MASK) { > > > + continue; > > > + } > > > > Always use scripts/checkpatch.pl on your patches so you do not get grumpy > > emails from maintainers telling you to use scripts/checkpatch.pl on your > > patches... > Indeed, I run the script before sending patch > ./scripts/checkpatch.pl 0001-tty-serial-fsl_lpuart-minimum-baud-rate-support.patch > total: 0 errors, 0 warnings, 10 lines checked > > 0001-tty-serial-fsl_lpuart-minimum-baud-rate-support.patch has no obvious style problems and is ready for submission. Ok, then something is wrong as there is obviously a coding style issue with your submission, as you can see with a manual review of it, right? greg k-h