From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>,
Rajendra Nayak <rnayak@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robdclark@chromium.org, robdclark@gmail.com,
stanimir.varbanov@linaro.org, mka@chromium.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Akash Asthana <akashast@codeaurora.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v6 1/6] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state
Date: Tue, 30 Jun 2020 08:35:52 +0530 [thread overview]
Message-ID: <20200630030552.cfp5oh33qde6nlnf@vireshk-i7> (raw)
In-Reply-To: <a3d53f82-b29d-97ef-3ba1-ca9bd650d354@codeaurora.org>
On 30-06-20, 08:31, Rajendra Nayak wrote:
>
>
> On 6/30/2020 4:47 AM, Stephen Boyd wrote:
> > Quoting Rajendra Nayak (2020-06-15 05:02:39)
> > > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> > > index 457c0bf..a90f8ec 100644
> > > --- a/drivers/tty/serial/qcom_geni_serial.c
> > > +++ b/drivers/tty/serial/qcom_geni_serial.c
> > > @@ -9,6 +9,7 @@
> > > #include <linux/module.h>
> > > #include <linux/of.h>
> > > #include <linux/of_device.h>
> > > +#include <linux/pm_opp.h>
> > > #include <linux/platform_device.h>
> > > #include <linux/pm_runtime.h>
> > > #include <linux/pm_wakeirq.h>
> > > @@ -962,7 +963,7 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport,
> > > goto out_restart_rx;
> > > uport->uartclk = clk_rate;
> > > - clk_set_rate(port->se.clk, clk_rate);
> > > + dev_pm_opp_set_rate(uport->dev, clk_rate);
> >
> > If there isn't an OPP table for the device because it is optional then
> > how can we unconditionally call dev_pm_opp_set_rate()?
Looks like some *Maintainers* aren't paying enough attention lately ;)
Just kidding.
> because we have 'aca48b6 opp: Manage empty OPP tables with clk handle' to handle this.
--
viresh
next prev parent reply other threads:[~2020-06-30 3:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1592222564-13556-1-git-send-email-rnayak@codeaurora.org>
2020-06-15 12:02 ` [PATCH v6 1/6] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state Rajendra Nayak
2020-06-25 5:08 ` Bjorn Andersson
2020-06-30 12:16 ` Rajendra Nayak
2020-06-29 23:17 ` Stephen Boyd
2020-06-30 3:01 ` Rajendra Nayak
2020-06-30 3:05 ` Viresh Kumar [this message]
2020-07-21 8:43 ` Stephen Boyd
2020-07-22 5:24 ` Viresh Kumar
2020-08-20 10:45 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630030552.cfp5oh33qde6nlnf@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=stanimir.varbanov@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).