From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Winkler <danielwinkler@google.com>
Cc: linux-serial@vger.kernel.org, linux-mediatek@lists.infradead.org,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
BlueZ <linux-bluetooth@vger.kernel.org>,
chromeos-bluetooth-upstreaming
<chromeos-bluetooth-upstreaming@chromium.org>,
stable@vger.kernel.org, abhishekpandit@chromium.org,
Aaron Sierra <asierra@xes-inc.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jiri Slaby <jslaby@suse.com>, Lukas Wunner <lukas@wunner.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Revert "serial: 8250: Fix max baud limit in generic 8250 port"
Date: Thu, 2 Jul 2020 09:36:07 +0200 [thread overview]
Message-ID: <20200702073607.GD1073011@kroah.com> (raw)
In-Reply-To: <20200701141329.v2.1.I2cc415fa5793b3e55acfd521ba8f0a71e79aa5f1@changeid>
On Wed, Jul 01, 2020 at 02:13:37PM -0700, Daniel Winkler wrote:
> This reverts commit 7b668c064ec33f3d687c3a413d05e355172e6c92.
>
I need a reason _why_ to revert this in the changelog text. Your 0/1
comments would be great to see in here, otherwise I have no idea what is
going on when I look at the kernel changelog in the future.
> Fixes: 7b668c064ec3 ("serial: 8250: Fix max baud limit in generic 8250
> port")
Nit, in the future, this line does not need to be wrapped at all, just
let it go the full length please.
thanks,
greg k-h
next prev parent reply other threads:[~2020-07-02 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 21:13 [PATCH v2 0/1] Revert "serial: 8250: Fix max baud limit in generic 8250 port" Daniel Winkler
2020-07-01 21:13 ` [PATCH v2 1/1] " Daniel Winkler
2020-07-02 7:36 ` Greg Kroah-Hartman [this message]
2020-07-01 22:37 ` [PATCH v2 0/1] " Serge Semin
2020-07-02 4:11 ` Lukas Wunner
2020-07-02 8:46 ` Andy Shevchenko
2020-07-02 7:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702073607.GD1073011@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=abhishekpandit@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=asierra@xes-inc.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=danielwinkler@google.com \
--cc=jslaby@suse.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=stable@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).