From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andreas Färber" <afaerber@suse.de>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Jiri Slaby" <jslaby@suse.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org
Subject: Re: [PATCH 1/1] tty: serial: owl: Initialize lock before registering port
Date: Fri, 10 Jul 2020 19:30:22 +0300 [thread overview]
Message-ID: <20200710163022.GT3703480@smile.fi.intel.com> (raw)
In-Reply-To: <20200710155806.GA10457@BV030612LT>
On Fri, Jul 10, 2020 at 06:58:06PM +0300, Cristian Ciocaltea wrote:
> On Fri, Jul 10, 2020 at 03:35:42PM +0200, Greg Kroah-Hartman wrote:
> > On Fri, Jul 10, 2020 at 03:05:49PM +0300, Cristian Ciocaltea wrote:
...
> > But I think we now have a core fix for this, no need to do this in any
> > individual driver, right? Can you test my tty-linus branch to see if
> > your change is still needed or not?
>
> I was not aware of the alternative approach, at that time Andy
> confirmed the expected behaviour is to have a proper initialization
> of the spinlock in the driver:
> https://lore.kernel.org/lkml/CAHp75Vcz0a87LSnb6Ubt5_bSF3wUcs21GbP119trXER5KBDxbQ@mail.gmail.com/
> https://lore.kernel.org/lkml/CAHp75Vf8xJ2yX-11JsTDnRvZQOK+16aePcB1AUzq=5oO-mFCGQ@mail.gmail.com/
>
> I have just checked the tty-linus tree and the only related change
> seems to be f743061a85f5
> ("serial: core: Initialise spin lock before use in uart_configure_port()")
>
> I tested it on top of 5.8.0-rc4 and I confirm it fixes the splat,
Thank you for the testing!
> however I'm a bit confused now regarding the recommended approach since
> there is at least one more commit in the tty-linux tree that still
> handles a similar issue in the driver specific code:
> f38278e9b810 ("serial: sh-sci: Initialize spinlock for uart console")
They now should be reverted.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-10 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 11:06 [PATCH 1/1] tty: serial: owl: Initialize lock before registering port Cristian Ciocaltea
2020-05-29 11:34 ` Greg Kroah-Hartman
2020-05-29 11:53 ` Andreas Färber
2020-05-29 12:03 ` Andy Shevchenko
2020-07-10 12:05 ` Cristian Ciocaltea
2020-07-10 13:35 ` Greg Kroah-Hartman
2020-07-10 15:58 ` Cristian Ciocaltea
2020-07-10 16:30 ` Andy Shevchenko [this message]
2020-07-11 6:30 ` Greg Kroah-Hartman
2020-07-11 13:55 ` Andy Shevchenko
2020-05-29 11:35 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710163022.GT3703480@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=afaerber@suse.de \
--cc=cristian.ciocaltea@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).