From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 4/5] Revert "serial: imx: Initialize lock for non-registered console"
Date: Sat, 11 Jul 2020 16:53:45 +0300 [thread overview]
Message-ID: <20200711135346.71171-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200711135346.71171-1-andriy.shevchenko@linux.intel.com>
This reverts commit 8f065acec7573672dd15916e31d1e9b2e785566c.
There has been a quick fix against uninitialised lock revealed by
the commit f743061a85f5 ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.
Fixes: 8f065acec757 ("serial: imx: Initialize lock for non-registered console")
Depends-on: f743061a85f5 ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/tty/serial/imx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 1265e8d86d8a..6175f8398130 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -2406,9 +2406,6 @@ static int imx_uart_probe(struct platform_device *pdev)
}
}
- /* We need to initialize lock even for non-registered console */
- spin_lock_init(&sport->port.lock);
-
imx_uart_ports[sport->port.line] = sport;
platform_set_drvdata(pdev, sport);
--
2.27.0
next prev parent reply other threads:[~2020-07-11 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-11 13:53 [PATCH v1 1/5] Revert "serial: sunhv: Initialize lock for non-registered console" Andy Shevchenko
2020-07-11 13:53 ` [PATCH v1 2/5] Revert "serial: amba-pl011: Make sure we initialize the port.lock spinlock" Andy Shevchenko
2020-07-11 13:53 ` [PATCH v1 3/5] Revert "tty: serial: add missing spin_lock_init for SiFive serial console" Andy Shevchenko
2020-07-11 13:53 ` Andy Shevchenko [this message]
2020-07-11 13:53 ` [PATCH v1 5/5] Revert "serial: sh-sci: Initialize spinlock for uart console" Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711135346.71171-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).