linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: B K Karthik <bkkarthik@pesu.pes.edu>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tty: serial: fsl_lpuart.c: prevent a bad shift operation
Date: Tue, 21 Jul 2020 19:33:13 +0200	[thread overview]
Message-ID: <20200721173313.GA2461958@kroah.com> (raw)
In-Reply-To: <20200721171311.xlt256fq2qmw4e6p@pesu.pes.edu>

On Tue, Jul 21, 2020 at 10:43:11PM +0530, B K Karthik wrote:
> prevent a bad shift operation by verifying that
> sport->rx_dma_rng_buf_len is non zero.
> 
> Signed-off-by: B K Karthik <bkkarthik@pesu.pes.edu>
> ---
>  drivers/tty/serial/fsl_lpuart.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

What about setting the "Reported-by:" to the person who reported this
problem?  And cc:ing them to see if they agree with your change?

thanks,

greg k-h

      reply	other threads:[~2020-07-21 17:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 17:13 [PATCH 1/2] tty: serial: fsl_lpuart.c: prevent a bad shift operation B K Karthik
2020-07-21 17:33 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200721173313.GA2461958@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bkkarthik@pesu.pes.edu \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).