From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Maxime Ripard <mripard@kernel.org>, Will Deacon <will@kernel.org>,
Russell King <linux@armlinux.org.uk>,
<linux-arm-kernel@lists.infradead.org>,
<linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v9 3/4] serial: 8250_dw: Pass the same rate to the clk round and set rate methods
Date: Thu, 23 Jul 2020 03:33:56 +0300 [thread overview]
Message-ID: <20200723003357.26897-4-Sergey.Semin@baikalelectronics.ru> (raw)
In-Reply-To: <20200723003357.26897-1-Sergey.Semin@baikalelectronics.ru>
Indeed according to the clk API if clk_round_rate() has successfully
accepted a rate, then in order setup the clock with value returned by the
clk_round_rate() the clk_set_rate() method must be called with the
original rate value.
Suggested-by: Russell King <linux@armlinux.org.uk>
Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
Changelog v8:
- This is a new patch created by the Russell King suggestion.
---
drivers/tty/serial/8250/8250_dw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 12866083731d..c1511f9244bb 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -275,15 +275,15 @@ dw8250_do_pm(struct uart_port *port, unsigned int state, unsigned int old)
static void dw8250_set_termios(struct uart_port *p, struct ktermios *termios,
struct ktermios *old)
{
- unsigned int baud = tty_termios_baud_rate(termios);
+ unsigned long newrate = tty_termios_baud_rate(termios) * 16;
struct dw8250_data *d = to_dw8250_data(p->private_data);
long rate;
int ret;
clk_disable_unprepare(d->clk);
- rate = clk_round_rate(d->clk, baud * 16);
+ rate = clk_round_rate(d->clk, newrate);
if (rate > 0) {
- ret = clk_set_rate(d->clk, rate);
+ ret = clk_set_rate(d->clk, newrate);
if (!ret)
p->uartclk = rate;
}
--
2.26.2
next prev parent reply other threads:[~2020-07-23 0:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 0:33 [PATCH v9 0/4] serial: 8250_dw: Fix ref clock usage Serge Semin
2020-07-23 0:33 ` [PATCH v9 1/4] serial: 8250: Add 8250 port clock update method Serge Semin
2024-02-14 13:45 ` Andy Shevchenko
2024-02-15 19:32 ` Serge Semin
2024-02-15 19:39 ` Andy Shevchenko
2024-02-16 17:19 ` Serge Semin
2024-02-19 15:08 ` Andy Shevchenko
2024-02-22 14:55 ` Serge Semin
2020-07-23 0:33 ` [PATCH v9 2/4] serial: 8250_dw: Simplify the ref clock rate setting procedure Serge Semin
2020-07-23 0:33 ` Serge Semin [this message]
2020-07-23 0:33 ` [PATCH v9 4/4] serial: 8250_dw: Fix common clocks usage race condition Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723003357.26897-4-Sergey.Semin@baikalelectronics.ru \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Pavel.Parkhomenko@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mripard@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).