From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E440C433DF for ; Thu, 23 Jul 2020 12:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06BEB20709 for ; Thu, 23 Jul 2020 12:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595506484; bh=aa0st7MvNM8jSVXdEskY+UH26gXhBB0AvK1AtY3EmM0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hqDKf3UpvbJnLVVPU4JM3Qs/d5AACLw6cBB0Z1RZTcauklqZZ5T/fuvxuwRHp6+Qv iOU7hff9RA+DdZ7TPmJ/NFqYq5i2qvWfH2Rifaitvo6IOoG7KiJPLSGMMnZHENMeST 9Ex5IkDzHididcK5mvPZ1CG5WWR8b0l6fU0POLgM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727885AbgGWMOn (ORCPT ); Thu, 23 Jul 2020 08:14:43 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:37217 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbgGWMOn (ORCPT ); Thu, 23 Jul 2020 08:14:43 -0400 Received: by mail-lj1-f195.google.com with SMTP id q6so6076360ljp.4; Thu, 23 Jul 2020 05:14:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=De5ujUjaEtGy1IVbJ3mPu69B3vuyGVhsBXi/4yWBrCQ=; b=B4D2DMyx3dGEfJAhrME4U7DpChRGrRW6wWBQ8GGzEtYqHq2Q7J4U1GL+l/enOB/Vzn 71MhdKMP9sujO6zoXtWunwbXvF6P1khtebouJ7szreAr3hB59rDcyt0xoGyGQAm6MKue bCj7aXEdLkxQMZTP/IpQrgUQ72SyIuM2oCIyZ+Wb9mmlQqmArHxruVyFcBP0oE4Hcswe 6ro6sKWJJi3ukklfdrKLeXN9DTpzrZ9zIl7q9zOmnPIzsbxZiRlh8ZkYMr4G3IAIJVwh ThLm5IzX9cLDyHcmDrq8ezpL+P0gVCvvlskj+3PutYyjVxYZ4BoKWEg3sxr2sgITRz4n AAiQ== X-Gm-Message-State: AOAM5321BuheSqqiALATAkBU+CzoqEK8Fia2qXN2ArUzFL3BglagVVuI oqvrCRm+JxpAB4nzItMMl5I= X-Google-Smtp-Source: ABdhPJwVeCeM+oMcVcVcAaL0Apf9n1njpIkpd2GwGhMo1iHD3WZwjv5BcVuQ32s9cliSx1fJI3IvoQ== X-Received: by 2002:a2e:880c:: with SMTP id x12mr1977174ljh.375.1595506480654; Thu, 23 Jul 2020 05:14:40 -0700 (PDT) Received: from xi.terra (c-beaee455.07-184-6d6c6d4.bbcust.telenor.se. [85.228.174.190]) by smtp.gmail.com with ESMTPSA id y18sm2625557ljn.62.2020.07.23.05.14.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 05:14:39 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.93.0.4) (envelope-from ) id 1jya7O-0006JQ-9v; Thu, 23 Jul 2020 14:14:34 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , kernel test robot Subject: [PATCH 1/2] serial: pmac_zilog: add sparse context annotation Date: Thu, 23 Jul 2020 14:14:22 +0200 Message-Id: <20200723121423.24217-2-johan@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200723121423.24217-1-johan@kernel.org> References: <20200723121423.24217-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org Add sparse context annotation to the receive handler, which releases and reacquires the port lock, to silence a sparse warning: drivers/tty/serial/pmac_zilog.c:255:36: sparse: sparse: context imbalance in 'pmz_receive_chars' - unexpected unlock Reported-by: kernel test robot Signed-off-by: Johan Hovold --- drivers/tty/serial/pmac_zilog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c index ba65a3bbd72a..b0d8f4a6f9b4 100644 --- a/drivers/tty/serial/pmac_zilog.c +++ b/drivers/tty/serial/pmac_zilog.c @@ -213,6 +213,7 @@ static void pmz_interrupt_control(struct uart_pmac_port *uap, int enable) } static bool pmz_receive_chars(struct uart_pmac_port *uap) + __must_hold(uap->port.lock) { struct tty_port *port; unsigned char ch, r1, drop, flag; -- 2.26.2