From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17B4C433E5 for ; Tue, 28 Jul 2020 08:36:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA8F120838 for ; Tue, 28 Jul 2020 08:36:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728247AbgG1IgY (ORCPT ); Tue, 28 Jul 2020 04:36:24 -0400 Received: from muru.com ([72.249.23.125]:38292 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728009AbgG1IgY (ORCPT ); Tue, 28 Jul 2020 04:36:24 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 61D5B8105; Tue, 28 Jul 2020 08:36:20 +0000 (UTC) Date: Tue, 28 Jul 2020 01:36:31 -0700 From: Tony Lindgren To: Pavel Machek Cc: Johan Hovold , Greg Kroah-Hartman , Rob Herring , Alan Cox , Lee Jones , Jiri Slaby , Merlijn Wajer , Peter Hurley , Sebastian Reichel , linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCHv8 0/6] n_gsm serdev support and GNSS driver for droid4 Message-ID: <20200728083631.GE2811@atomide.com> References: <20200512214713.40501-1-tony@atomide.com> <20200528083918.GB10358@localhost> <20200726082520.GA16953@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200726082520.GA16953@amd> Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org * Pavel Machek [200726 08:25]: > Hi! > > > > Here's the updated set of these patches fixed up for Johan's and > > > Pavel's earlier comments. > > > > > > This series does the following: > > > > > > 1. Adds functions to n_gsm.c for serdev-ngsm.c driver to use > > > > > > 2. Adds a generic serdev-ngsm.c driver that brings up the TS 27.010 > > > TTY ports configured in devicetree with help of n_gsm.c > > > > > > 3. Allows the use of standard Linux device drivers for dedicated > > > TS 27.010 channels for devices like GNSS and ALSA found on some > > > modems for example > > > > Unfortunately that does not seem to be the case just yet. Your gnss > > driver is still aware that it's using n_gsm for the transport and calls > > into the "parent" serdev-ngsm driver instead of using the serdev > > interface (e.g. as if this was still and MFD driver). > > > > If you model this right, the GNSS driver should work equally well > > regardless of whether you use the serial interface (with n_gsm) or USB > > (e.g. cdc-acm or usb-serial). > > We are not going to see that protocol anywhere else, so why is that > a good goal? Yes it seems this GNSS implementation is different from the one provided by gobi. > Anyway, Tony, is there newer version of this patchset? It would be > good to get something in... Sorry it will likely be few more weeks before I can look at this stuff again. > Can I help somehow? I think I'm pretty clear on what needs to be done regarding this patchset. Probably taking a look at if we could implement a minimal raw /dev/gsmtty* read/write access in ofono using ell instead of gatchat would help most :) So something that mbim modem is already doing I think, sorry have not had a chance to look at that either. The /dev/gsmtty* devices should not change even with the further changes to this patchset. Regards, Tony