From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Valmer Huhn <valmer.huhn@concurrent-rt.com>
Cc: gregkh@linuxfoundation.org, sudip.mukherjee@codethink.co.uk,
jan.kiszka@siemens.com, linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_exar: Bug fix for determination of number of ports for Commtech PCIe cards
Date: Thu, 13 Aug 2020 16:51:11 +0300 [thread overview]
Message-ID: <20200813135111.GW1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200812214937.GA332930@icarus.concurrent-rt.com>
On Wed, Aug 12, 2020 at 05:49:37PM -0400, Valmer Huhn wrote:
Thanks for the report. It needs a slight corrections I tell about below.
> serial: 8250_exar: Bug fix for determination of number of ports for
> Commtech PCIe cards
This should not be present in the body.
And in the subject it would be better to reduce the text to something like
serial: 8250_exar: Fix number of ports for Commtech PCIe cards
> The following line is used to determine the number of ports for each exar
> board in a/drivers/tty/serial/8250/8250_exar.c:589
There is no a/ folder and we don't need the full path anyway, just something
like '8250_exar.c line 589' is enough.
Also refer to Exar with capitalized name.
> nr_ports = board->num_ports ? board->num_ports : pcidev->device & 0x0f;
>
> If the number of ports a card has is not explicitly specified, it defaults
> to the rightmost 4 bits of the PCI device ID. This is prone to error since
> not all PCI device IDs contain a number which corresponds to the number of
> ports that card provides.
>
> This particular case involves COMMTECH_4224PCIE and COMMTECH_4228PCIE
> cards with device ID 0x0020 and 0x0021. Currently the multiport cards
'...with device IDs 0x0020, 0x0021 and 0x0022.'
> receive 0 and 1 port instead of 4 and 8 ports respectively.
and update this accordingly.
> To fix this, each Commtech Fastcom PCIe card is given a struct where the
> number of ports is explicitly specified. This ensures 'board->num_ports'
> is used instead of the default 'pcidev->device & 0x0f'.
Please, add a Fixes tag.
Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci")
> Signed-off-by: Valmer Huhn <valmer.huhn@concurrent-rt.com>
> Tested-by: Valmer Huhn <valmer.huhn@concurrent-rt.com>
...
> - EXAR_DEVICE(COMMTECH, 4222PCIE, pbn_exar_XR17V35x),
> - EXAR_DEVICE(COMMTECH, 4224PCIE, pbn_exar_XR17V35x),
> - EXAR_DEVICE(COMMTECH, 4228PCIE, pbn_exar_XR17V35x),
> + EXAR_DEVICE(COMMTECH, 4222PCIE, pbn_fastcom_XR17V352),
> + EXAR_DEVICE(COMMTECH, 4224PCIE, pbn_fastcom_XR17V354),
> + EXAR_DEVICE(COMMTECH, 4228PCIE, pbn_fastcom_XR17V358),
For sake of the consistency I would rather see them as
pbn_fastcom35x_2/4/8.
> EXAR_DEVICE(COMMTECH, 4222PCI335, pbn_fastcom335_2),
> EXAR_DEVICE(COMMTECH, 4224PCI335, pbn_fastcom335_4),
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-13 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 21:49 [PATCH] serial: 8250_exar: Bug fix for determination of number of ports for Commtech PCIe cards Valmer Huhn
2020-08-13 13:51 ` Andy Shevchenko [this message]
2020-08-13 16:42 ` Valmer Huhn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813135111.GW1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-serial@vger.kernel.org \
--cc=sudip.mukherjee@codethink.co.uk \
--cc=valmer.huhn@concurrent-rt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).