From: Jiri Slaby <jslaby@suse.cz>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: [PATCH 2/8] newport_con: fix no return statement in newport_show_logo
Date: Tue, 18 Aug 2020 10:56:49 +0200 [thread overview]
Message-ID: <20200818085655.12071-2-jslaby@suse.cz> (raw)
In-Reply-To: <20200818085655.12071-1-jslaby@suse.cz>
When CONFIG_LOGO_SGI_CLUT224 is unset, newport_show_logo contains no
return, despite it should return a pointer. Add one returning NULL to
fix a compiler warning:
drivers/video/console/newport_con.c: In function 'newport_show_logo':
drivers/video/console/newport_con.c:132:1: warning: no return statement in function returning non-void
Note that the caller expects NULL from the function already.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-fbdev@vger.kernel.org
Cc: linux-mips@vger.kernel.org
---
drivers/video/console/newport_con.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c
index 72f146d047d9..4d9110393479 100644
--- a/drivers/video/console/newport_con.c
+++ b/drivers/video/console/newport_con.c
@@ -131,6 +131,8 @@ static const struct linux_logo *newport_show_logo(void)
npregs->go.hostrw0 = *data++ << 24;
return logo;
+#else
+ return NULL;
#endif /* CONFIG_LOGO_SGI_CLUT224 */
}
--
2.28.0
next prev parent reply other threads:[~2020-08-18 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 8:56 [PATCH 1/8] tty: n_gsm, eliminate indirection for gsm->{output,error}() Jiri Slaby
2020-08-18 8:56 ` Jiri Slaby [this message]
2020-08-18 8:56 ` [PATCH 3/8] newport_con: make module's init & exit static using module_driver Jiri Slaby
2020-08-18 8:56 ` [PATCH 4/8] tty: fix kernel-doc Jiri Slaby
2020-08-18 8:56 ` [PATCH 5/8] tty: ldiscs, " Jiri Slaby
2020-08-18 8:56 ` [PATCH 6/8] tty: vt, " Jiri Slaby
2020-08-18 8:56 ` [PATCH 7/8] tty: synclink, " Jiri Slaby
2020-08-18 8:56 ` [PATCH 8/8] tty: serial, " Jiri Slaby
2020-08-18 11:52 ` [PATCH 1/8] tty: n_gsm, eliminate indirection for gsm->{output,error}() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818085655.12071-2-jslaby@suse.cz \
--to=jslaby@suse.cz \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).