From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C53C433E6 for ; Fri, 28 Aug 2020 08:20:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03E9320C56 for ; Fri, 28 Aug 2020 08:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598602808; bh=jTtvgXdgXo0t3/MzOxayXmzAhJPI6E7YTJCyNfRKXZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rcQVTqxN9cF8hs7yfrgZyvc1bY293RN0skd7d6MdsmqxpcjB9Zj634BUa0LKRpDZX 9QeMSaDv1UW8/HncZG29vnfmDZmlIB4E9GDx2LCNYkqosWzBWDnxWnXeyfHjwBcsBr gG049kG0gU5qqbDhVX8i6YEfcinwCOkRNH7/Yi78= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728660AbgH1IUH (ORCPT ); Fri, 28 Aug 2020 04:20:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:57446 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726834AbgH1IUD (ORCPT ); Fri, 28 Aug 2020 04:20:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4E34D20C56; Fri, 28 Aug 2020 08:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598602803; bh=jTtvgXdgXo0t3/MzOxayXmzAhJPI6E7YTJCyNfRKXZc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XQPJ1Diht17PhVRyodHgjYDLiIGXl6vC4HNWLdpVIqrKPv44aRpZ28FF6gNA1SoF1 NWuahBBcoV87EAbwbklx431kD7hwqR/Aa0FI/2G1xiDey+eltETQfqWoRw10qk5VpC aLU+8mqECl5kiCS/GA2agjbB6JIXiYMmAS2Zr+wI= Date: Fri, 28 Aug 2020 10:20:15 +0200 From: Greg KH To: Tong Zhang Cc: jirislaby@kernel.org, robh@kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH v4] tty: serial: earlycon dependency Message-ID: <20200828082015.GA1052883@kroah.com> References: <20200818162556.6621-1-ztong0001@gmail.com> <20200818185458.84418-1-ztong0001@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818185458.84418-1-ztong0001@gmail.com> Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Aug 18, 2020 at 02:54:59PM -0400, Tong Zhang wrote: > parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon > in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON > should automatically select SERIAL_CORE, otherwise will result in symbol > not found error during linking if SERIAL_CORE is not configured as builtin > > Signed-off-by: Tong Zhang > --- > > Fixes: 9aac5887595b ("tty/serial: add generic serial earlycon") This should be up above your signed-off-by line. Can you fix that up and resend? thanks, greg k-h